Skip to content

fix write from RTMR to solomon #5857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

uzhastik
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Jun 23, 2024

2024-06-23 08:38:09 UTC Pre-commit check for dc37f88 has started.
2024-06-23 08:40:28 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-23 08:42:54 UTC Build successful.
2024-06-23 08:43:11 UTC Tests are running...
🔴 2024-06-23 10:45:18 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9518 8932 0 85 331 170

🟢 2024-06-23 10:45:55 UTC ydbd size 5.5 GiB changed* by +13.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8cc0e51 merge: dc37f88 diff diff %
ydbd size 5 853 374 536 Bytes 5 853 387 912 Bytes +13.1 KiB +0.000%
ydbd stripped size 1 255 453 064 Bytes 1 255 455 880 Bytes +2.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 23, 2024

2024-06-23 08:38:40 UTC Pre-commit check for dc37f88 has started.
2024-06-23 08:41:13 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-23 08:44:42 UTC Build successful.

Copy link

github-actions bot commented Jun 23, 2024

2024-06-23 08:38:53 UTC Pre-commit check for dc37f88 has started.
2024-06-23 08:41:29 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-23 08:44:53 UTC Build successful.
2024-06-23 08:45:08 UTC Tests are running...
🔴 2024-06-23 10:48:46 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37793 32565 0 6 5212 10

🟢 2024-06-23 10:49:38 UTC ydbd size 8.3 GiB changed* by +600 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8cc0e51 merge: dc37f88 diff diff %
ydbd size 8 958 642 328 Bytes 8 958 642 928 Bytes +600 Bytes +0.000%
ydbd stripped size 488 345 896 Bytes 488 346 088 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-06-23 10:49:39 UTC Check cancelled

Copy link

github-actions bot commented Jun 23, 2024

2024-06-23 10:53:09 UTC Pre-commit check for ae8716f has started.
2024-06-23 10:55:38 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-23 11:30:06 UTC Build successful.

Copy link

github-actions bot commented Jun 23, 2024

2024-06-23 10:53:12 UTC Pre-commit check for ae8716f has started.
2024-06-23 10:55:44 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-23 10:58:30 UTC Build successful.
2024-06-23 10:58:46 UTC Tests are running...
🔴 2024-06-23 13:05:30 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9525 8945 0 87 322 171

🟢 2024-06-23 13:06:23 UTC ydbd size 5.5 GiB changed* by -298.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 450c3a2 merge: ae8716f diff diff %
ydbd size 5 855 799 056 Bytes 5 855 493 352 Bytes -298.5 KiB -0.005%
ydbd stripped size 1 255 749 704 Bytes 1 255 688 744 Bytes -59.5 KiB -0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 23, 2024

2024-06-23 10:53:16 UTC Pre-commit check for ae8716f has started.
2024-06-23 10:55:45 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-23 10:58:58 UTC Build successful.
2024-06-23 10:59:18 UTC Tests are running...
🔴 2024-06-23 12:56:09 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37793 32563 0 8 5212 10

🟢 2024-06-23 12:56:51 UTC ydbd size 8.3 GiB changed* by -555.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 450c3a2 merge: ae8716f diff diff %
ydbd size 8 963 003 632 Bytes 8 962 434 680 Bytes -555.6 KiB -0.006%
ydbd stripped size 488 478 952 Bytes 488 459 624 Bytes -18.9 KiB -0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@uzhastik uzhastik marked this pull request as ready for review June 23, 2024 13:11
@uzhastik uzhastik requested a review from a team as a code owner June 23, 2024 13:11
@uzhastik uzhastik merged commit b89687a into ydb-platform:main Jun 24, 2024
8 of 12 checks passed
@uzhastik uzhastik deleted the fix_rtmr_write_to_solomon branch June 24, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants