Skip to content

YDB-2321 Refactor IP UDF to use supported ipmath library #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 18, 2024
Merged

YDB-2321 Refactor IP UDF to use supported ipmath library #618

merged 11 commits into from
Jan 18, 2024

Conversation

avevad
Copy link
Contributor

@avevad avevad commented Dec 21, 2023

No description provided.

@avevad avevad requested a review from vitstn December 21, 2023 07:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2023 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-release-asan: some tests FAILED for commit 4ee2858.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14082 13945 0 34 73 30

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 4ee2858.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
57864 48682 0 7 9134 41

@avevad avevad requested review from vitstn and zverevgeny December 27, 2023 15:04
@avevad avevad requested a review from rvu1024 January 16, 2024 16:01
@avevad avevad requested a review from rvu1024 January 17, 2024 13:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2024 •
edited
Loading

⚪ 2024-01-17 16:22:26 UTC Pre-commit check for 7f2f82b has started.
⚪ 2024-01-17 16:22:27 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-17 16:25:53 UTC Build successful.
⚪ 2024-01-17 16:26:06 UTC Tests are running...
🔴 2024-01-17 17:39:29 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59943 50705 0 5 9218 15

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2024 •
edited
Loading

⚪ 2024-01-17 16:24:03 UTC Pre-commit check for 7f2f82b has started.
⚪ 2024-01-17 16:24:05 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-17 16:29:10 UTC Build successful.
⚪ 2024-01-17 16:29:37 UTC Tests are running...
🔴 2024-01-17 18:04:15 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15898 15803 0 25 59 11

Merge remote-tracking branch 'origin/ip-udf-refactoring' into ip-udf-…
7f2f82b 
…refactoring

# Conflicts:
#	ydb/library/yql/udfs/common/ip_base/lib/ip_base_udf.h
#	ydb/library/yql/udfs/common/ip_base/lib/ya.make
@avevad avevad requested a review from rvu1024 January 17, 2024 16:22
@rvu1024 rvu1024 merged commit 21bfb72 into ydb-platform:main Jan 18, 2024
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Jan 18, 2024
@dorooleg
YDB-2321 Refactor IP UDF to use supported ipmath library (ydb-platfor…
e71825c 
…m#618)

* Apply patch with changes

* Add & canonize some tests

* More refactoring

* Final cleanup

* Apply patch with changes

* Add & canonize some tests

* More refactoring

* Final cleanup

* Add explicit dependencies on library/cpp/ipv6_address
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 24, 2024
Merged
@FloatingCrowbar FloatingCrowbar mentioned this pull request Jan 24, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 25, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 25, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
avevad pushed a commit to avevad/ydb that referenced this pull request Mar 5, 2024
YDB-2321 Refactor IP UDF to use supported ipmath library (ydb-platfor…
e88f794 
…m#618)

* Apply patch with changes

* Add & canonize some tests

* More refactoring

* Final cleanup

* Apply patch with changes

* Add & canonize some tests

* More refactoring

* Final cleanup

* Add explicit dependencies on library/cpp/ipv6_address
uzhastik pushed a commit that referenced this pull request Mar 5, 2024
Cherry-pick IP UDF changes from main (#618 #981) (#2465)
96bc928
@avevad avevad deleted the ip-udf-refactoring branch January 17, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvu1024 rvu1024 rvu1024 approved these changes

@vitstn vitstn Awaiting requested review from vitstn

@zverevgeny zverevgeny Awaiting requested review from zverevgeny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avevad @vitstn @rvu1024