Skip to content

Refactor arrow kernels to include valueBuilder #6231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 11, 2024
Merged

Refactor arrow kernels to include valueBuilder #6231

merged 18 commits into from
Jul 11, 2024

Conversation

fedor-miron
Copy link
Contributor

@fedor-miron fedor-miron commented Jul 3, 2024 •
edited
Loading

Changelog entry

Refactor arrow kernels to include another argument (valueBuilder). It is required by Datetime UDF.

Changelog category

Additional information

...

@fedor-miron fedor-miron requested a review from a team as a code owner July 3, 2024 07:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

⚪ 2024-07-03 07:42:48 UTC Pre-commit check for 3dcc785 has started.
⚪ 2024-07-03 07:45:33 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-03 08:13:40 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

⚪ 2024-07-03 07:43:01 UTC Pre-commit check for 3dcc785 has started.
⚪ 2024-07-03 07:45:56 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-03 08:10:32 UTC Build failed. see the build logs.
🔴 2024-07-03 08:10:34 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

⚪ 2024-07-03 07:45:02 UTC Pre-commit check for 3dcc785 has started.
⚪ 2024-07-03 07:47:49 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-03 08:06:36 UTC Build failed. see the build logs.
🔴 2024-07-03 08:06:37 UTC Tests run skipped.

@fedor-miron fedor-miron requested a review from igormunkin July 8, 2024 09:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

⚪ 2024-07-08 10:45:43 UTC Pre-commit check for 4658d84 has started.
⚪ 2024-07-08 10:49:09 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-07-08 10:51:04 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

⚪ 2024-07-08 10:49:32 UTC Pre-commit check for 4658d84 has started.
⚫ 2024-07-08 10:51:03 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

⚪ 2024-07-08 10:58:46 UTC Pre-commit check for 4257cb6 has started.
⚪ 2024-07-08 11:02:01 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-08 11:18:36 UTC Build failed. see the build logs.
🔴 2024-07-08 11:18:37 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

⚪ 2024-07-08 11:10:03 UTC Pre-commit check for 4257cb6 has started.
⚪ 2024-07-08 11:12:53 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-08 11:29:15 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

⚪ 2024-07-08 11:11:26 UTC Pre-commit check for 4257cb6 has started.
⚪ 2024-07-08 11:14:30 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-08 11:30:00 UTC Build failed. see the build logs.
🔴 2024-07-08 11:30:01 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

⚪ 2024-07-08 13:37:58 UTC Pre-commit check for 39a5b18 has started.
⚪ 2024-07-08 13:41:27 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-08 13:55:12 UTC Build failed. see the build logs.
🔴 2024-07-08 13:55:14 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

⚪ 2024-07-08 13:47:31 UTC Pre-commit check for 39a5b18 has started.
⚪ 2024-07-08 13:50:56 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-08 13:57:59 UTC Build failed. see the build logs.
🔴 2024-07-08 13:58:00 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

⚪ 2024-07-08 13:48:34 UTC Pre-commit check for 39a5b18 has started.
⚪ 2024-07-08 13:51:47 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-08 14:04:03 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

⚪ 2024-07-08 14:43:13 UTC Pre-commit check for c78925f has started.
⚪ 2024-07-08 14:46:34 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-08 14:58:49 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

⚪ 2024-07-08 14:50:36 UTC Pre-commit check for c78925f has started.
⚪ 2024-07-08 14:54:11 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-08 15:40:22 UTC Build successful.
⚪ 2024-07-08 15:40:33 UTC Tests are running...
🔴 2024-07-08 17:49:13 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76240 62768 0 33 13428 11

🟡 2024-07-08 17:49:55 UTC ydbd size 8.1 GiB changed* by +545.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: cc81c7e merge: c78925f diff diff %
ydbd size 8 709 596 768 Bytes 8 710 155 792 Bytes +545.9 KiB +0.006%
ydbd stripped size 475 600 376 Bytes 475 681 336 Bytes +79.1 KiB +0.017%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

⚪ 2024-07-08 14:54:03 UTC Pre-commit check for c78925f has started.
⚪ 2024-07-08 14:57:28 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-08 15:23:52 UTC Build successful.
⚪ 2024-07-08 15:24:09 UTC Tests are running...
🔴 2024-07-08 17:31:09 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15187 14570 0 94 350 173

🟢 2024-07-08 17:31:54 UTC ydbd size 5.2 GiB changed* by -159.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 056e4b5 merge: c78925f diff diff %
ydbd size 5 606 207 064 Bytes 5 606 043 736 Bytes -159.5 KiB -0.003%
ydbd stripped size 1 206 553 464 Bytes 1 206 451 160 Bytes -99.9 KiB -0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@igormunkin igormunkin added the area/yql YQL query language issues label Jul 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

⚪ 2024-07-08 19:57:52 UTC Pre-commit check for 79dee3a has started.
⚪ 2024-07-08 20:00:41 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-08 20:29:04 UTC Build successful.
⚪ 2024-07-08 20:29:21 UTC Tests are running...
🔴 2024-07-08 22:37:14 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15190 14564 0 103 345 178

🟢 2024-07-08 22:38:01 UTC ydbd size 5.2 GiB changed* by -159.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: a75dd38 merge: 79dee3a diff diff %
ydbd size 5 595 990 576 Bytes 5 595 827 240 Bytes -159.5 KiB -0.003%
ydbd stripped size 1 203 433 880 Bytes 1 203 331 576 Bytes -99.9 KiB -0.009%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

⚪ 2024-07-08 19:58:18 UTC Pre-commit check for 79dee3a has started.
⚪ 2024-07-08 20:01:30 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-08 20:42:48 UTC Build successful.
⚪ 2024-07-08 20:43:00 UTC Tests are running...
🔴 2024-07-08 22:43:27 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76243 62765 0 34 13429 15

🟢 2024-07-08 22:44:10 UTC ydbd size 8.1 GiB changed* by -13.5 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0e03b2f merge: 79dee3a diff diff %
ydbd size 8 709 657 552 Bytes 8 695 549 016 Bytes -13.5 MiB -0.162%
ydbd stripped size 475 604 088 Bytes 474 740 792 Bytes -843.1 KiB -0.182%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

⚪ 2024-07-08 20:05:18 UTC Pre-commit check for 79dee3a has started.
⚪ 2024-07-08 20:08:53 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-08 20:20:14 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 09:35:08 UTC Pre-commit check for 5bb6ecc has started.
⚪ 2024-07-10 09:37:53 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-07-10 09:55:22 UTC Check cancelled

@fedor-miron fedor-miron force-pushed the block_state_valuebuilder branch from 4159e87 to 4884058 Compare July 10, 2024 09:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 10:01:52 UTC Pre-commit check for 348d509 has started.
⚪ 2024-07-10 10:05:16 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-10 10:10:59 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 10:07:28 UTC Pre-commit check for 348d509 has started.
⚪ 2024-07-10 10:10:44 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-10 10:50:35 UTC Build successful.
⚪ 2024-07-10 10:50:45 UTC Tests are running...
🔴 2024-07-10 13:08:15 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76248 62751 0 40 13435 22

🟡 2024-07-10 13:09:09 UTC ydbd size 8.1 GiB changed* by +516.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 483e9ee merge: 348d509 diff diff %
ydbd size 8 721 407 872 Bytes 8 721 936 920 Bytes +516.6 KiB +0.006%
ydbd stripped size 475 018 016 Bytes 475 090 720 Bytes +71.0 KiB +0.015%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

igormunkin
igormunkin previously approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@igormunkin igormunkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedor-miron, thanks for the fixes! LGTM, now.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 10:15:41 UTC Pre-commit check for 348d509 has started.
⚪ 2024-07-10 10:18:35 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-10 10:43:04 UTC Build successful.
⚪ 2024-07-10 10:43:19 UTC Tests are running...
🔴 2024-07-10 12:47:38 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15187 14572 0 94 342 179

🟢 2024-07-10 12:48:24 UTC ydbd size 5.2 GiB changed* by -165.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 483e9ee merge: 348d509 diff diff %
ydbd size 5 611 370 560 Bytes 5 611 200 928 Bytes -165.7 KiB -0.003%
ydbd stripped size 1 206 696 760 Bytes 1 206 594 456 Bytes -99.9 KiB -0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@fedor-miron fedor-miron changed the title Block state valuebuilder Refactor arrow kernels to include valueBuilder Jul 10, 2024
@fedor-miron fedor-miron enabled auto-merge (squash) July 10, 2024 11:19
vitstn
vitstn reviewed Jul 10, 2024
View reviewed changes
vitstn
vitstn requested changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@vitstn vitstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issues

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 15:49:15 UTC Pre-commit check for c211d42 has started.
⚪ 2024-07-10 15:52:34 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-10 16:07:47 UTC Build failed. see the build logs.
🔴 2024-07-10 16:07:49 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 15:58:17 UTC Pre-commit check for c211d42 has started.
⚪ 2024-07-10 16:01:36 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-10 16:11:29 UTC Build failed. see the build logs.
🔴 2024-07-10 16:11:30 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 17:11:48 UTC Pre-commit check for 8b02029 has started.
⚪ 2024-07-10 17:15:03 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-10 17:43:59 UTC Build successful.
⚪ 2024-07-10 17:44:13 UTC Tests are running...
🔴 2024-07-10 19:43:13 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15104 14518 0 81 327 178

🟢 2024-07-10 19:43:53 UTC ydbd size 5.2 GiB changed* by -165.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 11ed7b0 merge: 8b02029 diff diff %
ydbd size 5 604 712 688 Bytes 5 604 543 040 Bytes -165.7 KiB -0.003%
ydbd stripped size 1 206 060 272 Bytes 1 205 957 968 Bytes -99.9 KiB -0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 17:46:51 UTC Pre-commit check for 8b02029 has started.
⚪ 2024-07-10 17:49:43 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-10 18:11:21 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 17:47:16 UTC Pre-commit check for 8b02029 has started.
⚪ 2024-07-10 17:50:44 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-10 18:34:51 UTC Build successful.
⚪ 2024-07-10 18:35:08 UTC Tests are running...
🔴 2024-07-10 20:58:01 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76164 62684 0 34 13428 18

🟡 2024-07-10 20:58:53 UTC ydbd size 8.1 GiB changed* by +517.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 11ed7b0 merge: 8b02029 diff diff %
ydbd size 8 713 866 832 Bytes 8 714 396 688 Bytes +517.4 KiB +0.006%
ydbd stripped size 475 276 240 Bytes 475 349 008 Bytes +71.1 KiB +0.015%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@fedor-miron fedor-miron merged commit 75900f5 into ydb-platform:main Jul 11, 2024
8 of 12 checks passed
This was referenced Jul 12, 2024
Merged
Merged
Merged
This was referenced Jul 22, 2024
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitstn vitstn vitstn approved these changes

@igormunkin igormunkin igormunkin left review comments

Assignees

@fedor-miron fedor-miron

Labels
area/yql YQL query language issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedor-miron @vitstn @igormunkin