Skip to content

change error format for http handlers #6248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

adameat
Copy link
Member

@adameat adameat commented Jul 3, 2024

Changelog entry

change format of errors from text/plain to application/json

Changelog category

  • Improvement
  • Not for changelog (changelog entry is not required)

@adameat adameat requested a review from StekPerepolnen July 3, 2024 11:31
@adameat adameat requested a review from alexvru July 3, 2024 11:31
Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 12:21:34 UTC Pre-commit check for afa4580 has started.
2024-07-03 12:24:38 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-03 12:48:52 UTC Build successful.
2024-07-03 12:49:05 UTC Tests are running...
🔴 2024-07-03 14:53:50 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11026 10446 0 86 322 172

🟡 2024-07-03 14:54:43 UTC ydbd size 5.4 GiB changed* by +259.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: bd87563 merge: afa4580 diff diff %
ydbd size 5 814 908 560 Bytes 5 815 174 376 Bytes +259.6 KiB +0.005%
ydbd stripped size 1 247 931 016 Bytes 1 247 971 784 Bytes +39.8 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 12:37:11 UTC Pre-commit check for afa4580 has started.
2024-07-03 12:40:07 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-03 12:46:37 UTC Build successful.

Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 12:44:11 UTC Pre-commit check for afa4580 has started.
2024-07-03 12:46:52 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-03 13:26:50 UTC Build successful.
2024-07-03 13:27:05 UTC Tests are running...
🔴 2024-07-03 15:04:31 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15302 13983 0 1 1304 14

🟡 2024-07-03 15:05:09 UTC ydbd size 8.3 GiB changed* by +398.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: bd87563 merge: afa4580 diff diff %
ydbd size 8 926 807 928 Bytes 8 927 215 952 Bytes +398.5 KiB +0.005%
ydbd stripped size 486 814 568 Bytes 486 826 152 Bytes +11.3 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants