Skip to content

LongTxService subscription id #6250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented Jul 3, 2024

Changelog entry

The PQ tablet used a local LongTxService to subscribe to the WriteId status. Now the TWriteId contains the ID of the node where the subscription was registered.

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner July 3, 2024 12:24
@github-actions github-actions bot added the bugfix label Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 12:56:44 UTC Pre-commit check for dc9d35c has started.
2024-07-03 13:00:06 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-03 13:37:21 UTC Build successful.

Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 12:58:49 UTC Pre-commit check for dc9d35c has started.
2024-07-03 13:02:19 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-03 13:53:06 UTC Build successful.
2024-07-03 13:53:16 UTC Tests are running...
🔴 2024-07-03 13:54:12 UTC Test run completed, no test results found for commit 7555ed1. Please check test log.
🟡 2024-07-03 13:54:50 UTC ydbd size 5.4 GiB changed* by +167.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: bd87563 merge: dc9d35c diff diff %
ydbd size 5 814 908 560 Bytes 5 815 079 832 Bytes +167.3 KiB +0.003%
ydbd stripped size 1 247 931 016 Bytes 1 247 957 384 Bytes +25.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-07-03 13:54:51 UTC Check cancelled

Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 13:09:22 UTC Pre-commit check for dc9d35c has started.
2024-07-03 13:12:12 UTC Build linux-x86_64-relwithdebinfo is running...
2024-07-03 13:54:34 UTC Check cancelled

FloatingCrowbar
FloatingCrowbar previously approved these changes Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 14:44:03 UTC Pre-commit check for c8e6e17 has started.
2024-07-03 14:44:31 UTC Check cancelled

Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 15:05:38 UTC Pre-commit check for ad6a455 has started.
2024-07-03 15:08:32 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-03 15:57:28 UTC Build successful.
2024-07-03 15:57:43 UTC Tests are running...
🔴 2024-07-03 17:57:52 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11222 10639 0 87 322 174

🟢 2024-07-03 17:58:38 UTC ydbd size 5.3 GiB changed* by -98.1 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bd87563 merge: ad6a455 diff diff %
ydbd size 5 814 908 560 Bytes 5 712 049 664 Bytes -98.1 MiB -1.769%
ydbd stripped size 1 247 931 016 Bytes 1 235 274 632 Bytes -12.1 MiB -1.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 15:27:43 UTC Pre-commit check for ad6a455 has started.
2024-07-03 15:30:43 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-03 16:30:38 UTC Build successful.
2024-07-03 16:30:51 UTC Tests are running...
🔴 2024-07-03 18:35:08 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39700 34497 0 4 5186 13

🟢 2024-07-03 18:35:50 UTC ydbd size 8.2 GiB changed* by -144.8 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bd87563 merge: ad6a455 diff diff %
ydbd size 8 926 807 928 Bytes 8 775 001 864 Bytes -144.8 MiB -1.701%
ydbd stripped size 486 814 568 Bytes 482 686 184 Bytes -3.9 MiB -0.848%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 15:28:07 UTC Pre-commit check for ad6a455 has started.
2024-07-03 15:31:36 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-03 16:11:30 UTC Build successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants