Skip to content

Improvements in Write Actor #6251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 5, 2024
Merged

Improvements in Write Actor #6251

merged 10 commits into from
Jul 5, 2024

Conversation

nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Jul 3, 2024

Changelog entry

  • Fixed Memory Leak in sink
  • Got rid of retries in transactional sinks
  • Fixed RENAME in CTAS

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 13:04:02 UTC Pre-commit check for 083077f has started.
2024-07-03 13:06:54 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-03 13:42:15 UTC Build successful.

Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 13:04:27 UTC Pre-commit check for 083077f has started.
2024-07-03 13:07:12 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-03 13:52:06 UTC Build successful.
2024-07-03 13:57:28 UTC Tests are running...
🔴 2024-07-03 16:02:33 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11121 10540 0 83 323 175

🟡 2024-07-03 16:03:19 UTC ydbd size 5.4 GiB changed* by +192.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: bd87563 merge: 083077f diff diff %
ydbd size 5 814 908 560 Bytes 5 815 105 120 Bytes +192.0 KiB +0.003%
ydbd stripped size 1 247 931 016 Bytes 1 247 968 648 Bytes +36.8 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 13:46:18 UTC Pre-commit check for 083077f has started.
2024-07-03 13:49:03 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-03 14:49:45 UTC Build successful.
2024-07-03 14:50:00 UTC Tests are running...
🔴 2024-07-03 16:50:41 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39585 34383 0 3 5187 12

🟡 2024-07-03 16:51:20 UTC ydbd size 8.3 GiB changed* by +402.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: bd87563 merge: 083077f diff diff %
ydbd size 8 926 807 928 Bytes 8 927 220 248 Bytes +402.7 KiB +0.005%
ydbd stripped size 486 814 568 Bytes 486 822 248 Bytes +7.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 4, 2024

2024-07-04 06:38:07 UTC Pre-commit check for 60db425 has started.
2024-07-04 06:40:59 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-04 07:15:52 UTC Build successful.

Copy link

github-actions bot commented Jul 4, 2024

2024-07-04 06:38:12 UTC Pre-commit check for 60db425 has started.
2024-07-04 06:40:55 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-04 07:40:03 UTC Build successful.
2024-07-04 07:40:19 UTC Tests are running...
🔴 2024-07-04 09:35:56 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39624 34366 0 21 5222 15

🟡 2024-07-04 09:36:43 UTC ydbd size 8.2 GiB changed* by +148.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1064ddc merge: 60db425 diff diff %
ydbd size 8 775 503 896 Bytes 8 775 655 560 Bytes +148.1 KiB +0.002%
ydbd stripped size 482 710 312 Bytes 482 712 872 Bytes +2.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 4, 2024

2024-07-04 06:38:13 UTC Pre-commit check for 60db425 has started.
2024-07-04 06:40:55 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-04 07:21:16 UTC Build successful.
2024-07-04 07:21:32 UTC Tests are running...
🔴 2024-07-04 09:20:39 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11125 10521 0 106 324 174

🟢 2024-07-04 09:21:32 UTC ydbd size 5.3 GiB changed* by +81.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1064ddc merge: 60db425 diff diff %
ydbd size 5 712 433 488 Bytes 5 712 516 880 Bytes +81.4 KiB +0.001%
ydbd stripped size 1 235 350 248 Bytes 1 235 371 048 Bytes +20.3 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 requested review from a team as code owners July 4, 2024 16:13
Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 07:32:18 UTC Pre-commit check for 9ce36d1 has started.
2024-07-05 07:35:02 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-05 07:51:48 UTC Build successful.

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 07:32:24 UTC Pre-commit check for 9ce36d1 has started.
2024-07-05 07:35:09 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-05 08:03:51 UTC Build successful.
2024-07-05 08:04:09 UTC Tests are running...
🔴 2024-07-05 10:03:02 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11159 10578 0 82 325 174

🟡 2024-07-05 10:03:52 UTC ydbd size 5.2 GiB changed* by +105.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f60b60f merge: 9ce36d1 diff diff %
ydbd size 5 615 577 800 Bytes 5 615 686 032 Bytes +105.7 KiB +0.002%
ydbd stripped size 1 211 053 768 Bytes 1 211 080 072 Bytes +25.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 07:32:25 UTC Pre-commit check for 9ce36d1 has started.
2024-07-05 07:35:14 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-05 08:19:37 UTC Build successful.
2024-07-05 08:19:50 UTC Tests are running...
🔴 2024-07-05 10:08:09 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39662 34428 0 4 5219 11

🟡 2024-07-05 10:08:48 UTC ydbd size 8.1 GiB changed* by +178.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f60b60f merge: 9ce36d1 diff diff %
ydbd size 8 725 396 800 Bytes 8 725 580 040 Bytes +178.9 KiB +0.002%
ydbd stripped size 477 126 696 Bytes 477 134 888 Bytes +8.0 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 10:19:01 UTC Pre-commit check for 6948006 has started.
2024-07-05 10:21:51 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-05 10:22:05 UTC Build failed. see the build logs.
🔴 2024-07-05 10:22:06 UTC Tests run skipped.

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 10:25:56 UTC Pre-commit check for 6948006 has started.
2024-07-05 10:28:48 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-05 10:29:02 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 10:26:25 UTC Pre-commit check for 6948006 has started.
2024-07-05 10:29:11 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-05 10:29:24 UTC Build failed. see the build logs.
🔴 2024-07-05 10:29:25 UTC Tests run skipped.

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 10:43:42 UTC Pre-commit check for db21a8c has started.
2024-07-05 10:46:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-05 11:17:21 UTC Build successful.
2024-07-05 11:17:35 UTC Tests are running...
🔴 2024-07-05 13:19:12 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11158 10576 0 86 321 175

🟡 2024-07-05 13:20:03 UTC ydbd size 5.2 GiB changed* by +100.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 5fc09ca merge: db21a8c diff diff %
ydbd size 5 615 862 464 Bytes 5 615 965 336 Bytes +100.5 KiB +0.002%
ydbd stripped size 1 211 107 272 Bytes 1 211 129 288 Bytes +21.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 10:43:46 UTC Pre-commit check for db21a8c has started.
2024-07-05 10:46:32 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-05 11:28:56 UTC Build successful.
2024-07-05 11:29:14 UTC Tests are running...
🟢 2024-07-05 13:12:46 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39673 34439 0 0 5221 13

🟡 2024-07-05 13:13:28 UTC ydbd size 8.1 GiB changed* by +174.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 5fc09ca merge: db21a8c diff diff %
ydbd size 8 726 129 816 Bytes 8 726 308 080 Bytes +174.1 KiB +0.002%
ydbd stripped size 477 144 232 Bytes 477 148 264 Bytes +3.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 10:43:51 UTC Pre-commit check for db21a8c has started.
2024-07-05 10:46:44 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-05 11:05:59 UTC Build successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants