Skip to content

Less LLVM in block agg #6359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2024
Merged

Less LLVM in block agg #6359

merged 1 commit into from
Jul 8, 2024

Conversation

vitstn
Copy link
Collaborator

@vitstn vitstn commented Jul 5, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@vitstn vitstn requested a review from a team as a code owner July 5, 2024 18:29
@vitstn vitstn requested review from nepal and igormunkin July 5, 2024 18:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024 •
edited
Loading

⚪ 2024-07-05 18:36:19 UTC Pre-commit check for eb02691 has started.
⚪ 2024-07-05 18:38:51 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-05 19:03:54 UTC Build successful.
⚪ 2024-07-05 19:04:14 UTC Tests are running...
🔴 2024-07-05 21:04:58 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12227 11618 0 92 342 175

🟢 2024-07-05 21:05:54 UTC ydbd size 5.2 GiB changed* by -8.2 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bbe1921 merge: eb02691 diff diff %
ydbd size 5 615 813 224 Bytes 5 607 210 224 Bytes -8.2 MiB -0.153%
ydbd stripped size 1 211 147 616 Bytes 1 207 624 824 Bytes -3.4 MiB -0.291%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024 •
edited
Loading

⚪ 2024-07-05 18:36:39 UTC Pre-commit check for eb02691 has started.
⚪ 2024-07-05 18:39:18 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-05 19:19:54 UTC Build successful.
⚪ 2024-07-05 19:20:11 UTC Tests are running...
🔴 2024-07-05 21:30:50 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73266 59825 0 1 13428 12

🟢 2024-07-05 21:31:33 UTC ydbd size 8.1 GiB changed* by -12.7 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f5256d7 merge: eb02691 diff diff %
ydbd size 8 727 106 968 Bytes 8 713 742 768 Bytes -12.7 MiB -0.153%
ydbd stripped size 477 013 432 Bytes 475 928 952 Bytes -1.0 MiB -0.227%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024 •
edited
Loading

⚪ 2024-07-05 18:36:41 UTC Pre-commit check for eb02691 has started.
⚪ 2024-07-05 18:39:13 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-05 18:45:45 UTC Build successful.

@vitstn vitstn enabled auto-merge (squash) July 5, 2024 23:13
igormunkin
igormunkin approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@igormunkin igormunkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitstn, thanks for the patch! LGTM.

@vitstn vitstn merged commit d20552c into ydb-platform:main Jul 8, 2024
9 of 13 checks passed
@vitstn vitstn deleted the less_llvm_block_agg branch July 8, 2024 11:34
This was referenced Jul 9, 2024
Merged
Merged
Merged
This was referenced Jul 16, 2024
Merged
Merged
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igormunkin igormunkin igormunkin approved these changes

@nepal nepal Awaiting requested review from nepal

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitstn @igormunkin