Skip to content

lz4 decompressor has been fixed #6414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Conversation

dorooleg
Copy link
Collaborator

@dorooleg dorooleg commented Jul 8, 2024

Changelog entry

...

Changelog category

  • Bugfix

Additional information

...

@dorooleg dorooleg requested a review from a team as a code owner July 8, 2024 14:58
@github-actions github-actions bot added the bugfix label Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 15:07:53 UTC Pre-commit check for e90cc13 has started.
2024-07-08 15:10:23 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-08 15:14:18 UTC Build successful.

Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 15:14:07 UTC Pre-commit check for e90cc13 has started.
2024-07-08 15:17:01 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-08 15:53:04 UTC Build successful.
2024-07-08 15:53:19 UTC Tests are running...
🔴 2024-07-08 17:31:10 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38012 32777 0 2 5219 14

🟡 2024-07-08 17:31:46 UTC ydbd size 8.1 GiB changed* by +400.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7b59fef merge: e90cc13 diff diff %
ydbd size 8 709 190 328 Bytes 8 709 600 720 Bytes +400.8 KiB +0.005%
ydbd stripped size 475 593 016 Bytes 475 600 760 Bytes +7.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 15:15:07 UTC Pre-commit check for e90cc13 has started.
2024-07-08 15:18:06 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-08 15:39:31 UTC Build successful.
2024-07-08 15:39:40 UTC Tests are running...
🔴 2024-07-08 17:31:06 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9665 9093 0 80 320 172

🟢 2024-07-08 17:31:39 UTC ydbd size 5.2 GiB changed* by +4.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 056e4b5 merge: e90cc13 diff diff %
ydbd size 5 606 207 064 Bytes 5 606 211 624 Bytes +4.5 KiB +0.000%
ydbd stripped size 1 206 553 464 Bytes 1 206 554 424 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

while (Pos < Remaining || (decodedBytes == OutBuffer.size())) {
decodedBytes = OutBuffer.size();
NextToLoad = LZ4F_decompress_usingDict(Ctx, OutBuffer.data(), &decodedBytes, InBuffer.data() + Pos, &Remaining, nullptr, 0ULL, nullptr);
YQL_ENSURE(!LZ4F_isError(NextToLoad), "Decompression error: " << LZ4F_getErrorName(NextToLoad));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Давай тестом еще покроем парсинг битого архива, чтобы проверить текст ошибки

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 11:29:57 UTC Pre-commit check for 3ceca68 has started.
2024-07-12 11:32:35 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-12 13:31:34 UTC Build successful.
🔴 2024-07-12 13:34:41 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9404 8807 0 90 328 179

🟢 2024-07-12 13:35:24 UTC ydbd size 5.2 GiB changed* by +4.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f8e93d3 merge: 3ceca68 diff diff %
ydbd size 5 608 995 224 Bytes 5 608 999 640 Bytes +4.3 KiB +0.000%
ydbd stripped size 1 207 400 496 Bytes 1 207 401 520 Bytes +1.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 11:37:48 UTC Pre-commit check for 3ceca68 has started.
2024-07-12 11:40:28 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-12 11:45:51 UTC Build successful.

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 11:42:35 UTC Pre-commit check for 3ceca68 has started.
2024-07-12 11:45:13 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-12 13:35:53 UTC Build successful.
🔴 2024-07-12 13:43:07 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37753 32504 0 5 5223 21

🟢 2024-07-12 13:43:56 UTC ydbd size 8.1 GiB changed* by -536.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1d0798e merge: 3ceca68 diff diff %
ydbd size 8 719 353 752 Bytes 8 718 804 576 Bytes -536.3 KiB -0.006%
ydbd stripped size 475 749 872 Bytes 475 669 296 Bytes -78.7 KiB -0.017%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dorooleg dorooleg merged commit a303aa8 into ydb-platform:main Jul 15, 2024
8 of 12 checks passed
marsaly79 pushed a commit to marsaly79/ydb that referenced this pull request Jul 15, 2024
dorooleg added a commit to dorooleg/ydb that referenced this pull request Jul 19, 2024
dorooleg added a commit to dorooleg/ydb that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants