Skip to content

Remove OldHashSector in PDisk #6465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Conversation

maximyurchuk
Copy link
Collaborator

@maximyurchuk maximyurchuk commented Jul 9, 2024

Changelog entry

Continuing #6439

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Jul 9, 2024

2024-07-09 11:39:28 UTC Pre-commit check for 0335fd2 has started.
2024-07-09 11:42:27 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-09 11:45:48 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jul 9, 2024

2024-07-09 12:06:30 UTC Pre-commit check for 60a4e09 has started.
2024-07-09 12:09:29 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-09 12:24:52 UTC Build successful.

Copy link

github-actions bot commented Jul 9, 2024

2024-07-09 12:24:03 UTC Pre-commit check for 60a4e09 has started.
2024-07-09 12:27:07 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-09 12:53:45 UTC Build successful.
2024-07-09 12:53:56 UTC Tests are running...
🔴 2024-07-09 14:52:01 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10323 9737 0 85 322 179

🟢 2024-07-09 14:52:44 UTC ydbd size 5.2 GiB changed* by -143.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0fa3052 merge: 60a4e09 diff diff %
ydbd size 5 610 940 168 Bytes 5 610 792 864 Bytes -143.9 KiB -0.003%
ydbd stripped size 1 206 606 616 Bytes 1 206 592 536 Bytes -13.8 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 9, 2024

2024-07-09 12:59:39 UTC Pre-commit check for 60a4e09 has started.
2024-07-09 13:02:33 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-09 13:44:27 UTC Build successful.
2024-07-09 13:44:41 UTC Tests are running...
🔴 2024-07-09 15:03:58 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14606 13273 0 8 1308 17

🟢 2024-07-09 15:04:40 UTC ydbd size 8.1 GiB changed* by -265.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0fa3052 merge: 60a4e09 diff diff %
ydbd size 8 720 569 560 Bytes 8 720 297 240 Bytes -265.9 KiB -0.003%
ydbd stripped size 474 992 800 Bytes 474 982 496 Bytes -10.1 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk marked this pull request as ready for review July 9, 2024 14:32
alexvru
alexvru previously approved these changes Jul 9, 2024
Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 11:02:18 UTC Pre-commit check for dc34b61 has started.
2024-07-10 11:04:51 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-10 11:10:30 UTC Build successful.

Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 11:02:50 UTC Pre-commit check for dc34b61 has started.
2024-07-10 11:05:18 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-10 11:42:08 UTC Build successful.
2024-07-10 11:42:19 UTC Tests are running...
🔴 2024-07-10 12:58:13 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14606 13282 0 1 1306 17

🟢 2024-07-10 12:58:58 UTC ydbd size 8.1 GiB changed* by -7.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 483e9ee merge: dc34b61 diff diff %
ydbd size 8 721 407 872 Bytes 8 721 399 840 Bytes -7.8 KiB -0.000%
ydbd stripped size 475 018 016 Bytes 475 017 248 Bytes -768 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 11:10:22 UTC Pre-commit check for dc34b61 has started.
2024-07-10 11:12:52 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-10 11:35:46 UTC Build successful.
2024-07-10 11:35:59 UTC Tests are running...
🔴 2024-07-10 13:30:57 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10326 9739 0 80 326 181

🟢 2024-07-10 13:31:44 UTC ydbd size 5.2 GiB changed* by -4.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 483e9ee merge: dc34b61 diff diff %
ydbd size 5 611 370 560 Bytes 5 611 366 280 Bytes -4.2 KiB -0.000%
ydbd stripped size 1 206 696 760 Bytes 1 206 695 544 Bytes -1.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants