Skip to content

Merge some fixes #6490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Merge some fixes #6490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b58aba5
Fix pushdown JSON_EXISTS on runtime version 4. (#6332)
Tony-Romanov Jul 5, 2024
c67e5aa
Fix test of exotic XOR. (#6317)
Tony-Romanov Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ydb/core/kqp/query_compiler/kqp_olap_compiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,6 +856,8 @@ TTypedColumn GetOrCreateColumnIdAndType(const TExprBase& node, TKqpOlapCompileCo
return BuildLogicalNot(maybeNot.Cast().Value(), ctx);
} else if (const auto& maybeJsonValue = node.Maybe<TKqpOlapJsonValue>()) {
return ConvertJsonValueToColumn(maybeJsonValue.Cast(), ctx);
} else if (const auto& maybeJsonValue = node.Maybe<TKqpOlapJsonExists>()) {
return CompileJsonExists(maybeJsonValue.Cast(), ctx);
} else if (const auto& maybeApply = node.Maybe<TKqpOlapApply>()) {
return CompileYqlKernelScalarApply(maybeApply.Cast(), ctx);
}
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/kqp/ut/olap/kqp_olap_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,7 +939,6 @@ Y_UNIT_TEST_SUITE(KqpOlap) {
R"(`resource_id` = "10001")",
R"(`resource_id` != "10001")",
R"("XXX" == "YYY" OR `resource_id` != "10001")",
R"(`resource_id` != "10001" XOR "XXX" == "YYY")",
R"(`level` = 1)",
R"(`level` = Int8("1"))",
R"(`level` = Int16("1"))",
Expand Down Expand Up @@ -1021,6 +1020,7 @@ Y_UNIT_TEST_SUITE(KqpOlap) {
R"((`timestamp`, `level`) >= (Timestamp("1970-01-01T00:00:03.000001Z"), 3))",
#endif
#if SSA_RUNTIME_VERSION >= 5U
R"(`resource_id` != "10001" XOR "XXX" == "YYY")",
R"(IF(`level` > 3, -`level`, +`level`) < 2)",
R"(StartsWith(`message` ?? `resource_id`, "10000"))",
R"(NOT EndsWith(`message` ?? `resource_id`, "xxx"))",
Expand Down
Loading