Skip to content

grace_join: fix refactoring error #6711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Jul 15, 2024

Changelog entry

...

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

...

@yumkam yumkam requested a review from aakulaga-ydb July 15, 2024 16:53
Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 17:02:52 UTC Pre-commit check for d89cb25 has started.
2024-07-15 17:05:28 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-15 19:16:49 UTC Build successful.
🔴 2024-07-15 19:28:06 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72977 59514 0 13 13432 18

🟢 2024-07-15 19:28:46 UTC ydbd size 8.1 GiB changed* by -240 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8de5470 merge: d89cb25 diff diff %
ydbd size 8 687 152 568 Bytes 8 687 152 328 Bytes -240 Bytes -0.000%
ydbd stripped size 474 023 200 Bytes 474 023 200 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 17:04:56 UTC Pre-commit check for d89cb25 has started.
2024-07-15 17:08:02 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-15 19:13:33 UTC Build successful.
🔴 2024-07-15 19:16:55 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11925 11325 0 86 334 180

🟢 2024-07-15 19:17:38 UTC ydbd size 5.2 GiB changed* by +416 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8de5470 merge: d89cb25 diff diff %
ydbd size 5 570 833 832 Bytes 5 570 834 248 Bytes +416 Bytes +0.000%
ydbd stripped size 1 201 399 984 Bytes 1 201 399 856 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 17:07:29 UTC Pre-commit check for d89cb25 has started.
2024-07-15 17:10:36 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-15 17:16:35 UTC Build successful.

@yumkam yumkam marked this pull request as ready for review July 15, 2024 17:13
@yumkam yumkam requested a review from a team as a code owner July 15, 2024 17:13
@aakulaga-ydb aakulaga-ydb merged commit 2d3caea into ydb-platform:main Jul 16, 2024
9 of 13 checks passed
yumkam added a commit to yumkam/ydb that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants