Skip to content

BTreeIndex Precharge Simplification #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

kunga
Copy link
Member

@kunga kunga commented Dec 22, 2023

It's turned out that Charge(row1, row2) methods are the same that Charge(key1={}, key2={}, row1, row2), so I just removed them.

PR also contains some renames and tests for ChargeReverse(row1, row2) method.

@kunga kunga force-pushed the KIKIMR-19522-btree-precharge-first branch from dac766b to d42c83c Compare December 22, 2023 18:10
@kunga kunga changed the title test rows reverse KIKIMR-19522 BTreeIndex Precharge first Dec 22, 2023
Copy link

github-actions bot commented Dec 22, 2023

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit deb925a.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59399 50210 0 18 9133 38

🔴 linux-x86_64-release-asan: some tests FAILED for commit deb925a.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15617 15462 0 39 85 31

@kunga kunga changed the title KIKIMR-19522 BTreeIndex Precharge first KIKIMR-19522 BTreeIndex Precharge Simplify Dec 25, 2023
@kunga kunga marked this pull request as ready for review December 25, 2023 12:08
@kunga kunga requested a review from azevaykin December 25, 2023 12:08
@kunga kunga changed the title KIKIMR-19522 BTreeIndex Precharge Simplify KIKIMR-19522 BTreeIndex Precharge Simplification Dec 25, 2023
@kunga kunga merged commit 33e5f8b into ydb-platform:main Dec 26, 2023
@jepett0 jepett0 mentioned this pull request Dec 28, 2023
@StekPerepolnen StekPerepolnen mentioned this pull request Dec 29, 2023
Closed
adameat pushed a commit to adameat/ydb that referenced this pull request Dec 29, 2023
This was referenced Jan 3, 2024
This was referenced Jan 11, 2024
@kunga kunga linked an issue Feb 2, 2024 that may be closed by this pull request
62 tasks
@kunga kunga changed the title KIKIMR-19522 BTreeIndex Precharge Simplification BTreeIndex Precharge Simplification Feb 2, 2024
@kunga kunga mentioned this pull request Feb 2, 2024
62 tasks
@kunga kunga removed a link to an issue Feb 2, 2024
62 tasks
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants