Added parameter selectivity and boosted LookupJoin #6874

pavelvelikhov · 2024-07-19T13:04:06Z

Changelog entry

...

Changelog category

Improvement

Additional information

...

github-actions · 2024-07-19T13:05:18Z

⚪ 2024-07-19 13:05:18 UTC Pre-commit check for f0f0270 has started.
⚪ 2024-07-19 13:07:59 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-19 13:12:39 UTC Build successful.

github-actions · 2024-07-19T13:05:22Z

⚪ 2024-07-19 13:05:22 UTC Pre-commit check for f0f0270 has started.
⚪ 2024-07-19 13:08:07 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-19 15:15:42 UTC Build successful.
🔴 2024-07-19 15:18:48 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10230	9616	0	102	340	172

🔴 2024-07-19 15:21:52 UTC ydbd size 5.2 GiB changed* by +7.0 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash	main: `19153a4`	merge: `f0f0270`	diff	diff %
ydbd size	5 546 451 224 Bytes	5 553 785 464 Bytes	+7.0 MiB	+0.132%
ydbd stripped size	1 195 225 712 Bytes	1 196 607 312 Bytes	+1.3 MiB	+0.116%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-19T13:05:24Z

⚪ 2024-07-19 13:05:23 UTC Pre-commit check for f0f0270 has started.
⚪ 2024-07-19 13:08:16 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-19 15:20:12 UTC Build successful.
🔴 2024-07-19 15:28:19 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
71283	57828	0	6	13437	12

🔴 2024-07-19 15:29:03 UTC ydbd size 8.1 GiB changed* by +11.0 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash	main: `19153a4`	merge: `f0f0270`	diff	diff %
ydbd size	8 641 993 624 Bytes	8 653 526 312 Bytes	+11.0 MiB	+0.133%
ydbd stripped size	470 492 384 Bytes	470 999 424 Bytes	+495.2 KiB	+0.108%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-19T15:37:42Z

⚪ 2024-07-19 15:37:42 UTC Pre-commit check for 9164e3a has started.
⚪ 2024-07-19 15:40:31 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-19 17:47:09 UTC Build successful.
🔴 2024-07-19 17:50:40 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10230	9629	0	93	337	171

🔴 2024-07-19 17:51:30 UTC ydbd size 5.2 GiB changed* by +8.4 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash	main: `19153a4`	merge: `9164e3a`	diff	diff %
ydbd size	5 546 451 224 Bytes	5 555 276 888 Bytes	+8.4 MiB	+0.159%
ydbd stripped size	1 195 225 712 Bytes	1 196 890 832 Bytes	+1.6 MiB	+0.139%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-19T15:38:01Z

⚪ 2024-07-19 15:38:01 UTC Pre-commit check for 9164e3a has started.
⚪ 2024-07-19 15:41:00 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-19 15:50:02 UTC Build successful.

github-actions · 2024-07-19T15:38:04Z

⚪ 2024-07-19 15:38:04 UTC Pre-commit check for 9164e3a has started.
⚪ 2024-07-19 15:40:50 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-19 17:53:04 UTC Build successful.
🔴 2024-07-19 18:01:11 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
71291	57835	0	4	13438	14

🔴 2024-07-19 18:02:02 UTC ydbd size 8.1 GiB changed* by +13.0 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash	main: `19153a4`	merge: `9164e3a`	diff	diff %
ydbd size	8 641 993 624 Bytes	8 655 633 472 Bytes	+13.0 MiB	+0.158%
ydbd stripped size	470 492 384 Bytes	471 100 832 Bytes	+594.2 KiB	+0.129%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

spuchin · 2024-07-19T16:47:04Z

ydb/core/kqp/ut/join/kqp_flip_join_ut.cpp

@@ -203,7 +203,7 @@ Y_UNIT_TEST_SUITE(KqpFlipJoin) {

        auto result = ExecQueryAndTestResult(session, query, NoParams, R"([[[1];["Value11"]];[[2];["Value12"]]])");

-        AssertTableReads(result, "/Root/FJ_Table_1", 2);


А почему тут поменялось количество чтений?

Стало больше, но тут приграничная история, был 1 lookup и 1 map, так и осталось, просто таблицы другие

Added parameter selectivity and boosted LookupJoin

bb31395

pavelvelikhov requested review from a team as code owners July 19, 2024 13:04

github-actions bot added the improvement label Jul 19, 2024

resetius previously approved these changes Jul 19, 2024

View reviewed changes

Updated unit test

94c403e

pavelvelikhov dismissed resetius’s stale review via 94c403e July 19, 2024 15:36

pashandor789 approved these changes Jul 19, 2024

View reviewed changes

resetius approved these changes Jul 19, 2024

View reviewed changes

spuchin reviewed Jul 19, 2024

View reviewed changes

pavelvelikhov merged commit 315c7f3 into ydb-platform:main Jul 19, 2024
8 of 12 checks passed

pavelvelikhov added a commit to pavelvelikhov/ydb that referenced this pull request Sep 5, 2024

Added parameter selectivity and boosted LookupJoin (ydb-platform#6874)

033c22d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added parameter selectivity and boosted LookupJoin #6874

Added parameter selectivity and boosted LookupJoin #6874

pavelvelikhov commented Jul 19, 2024

github-actions bot commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024 •

edited

Loading

spuchin Jul 19, 2024

pavelvelikhov Jul 19, 2024

		@@ -203,7 +203,7 @@ Y_UNIT_TEST_SUITE(KqpFlipJoin) {

		auto result = ExecQueryAndTestResult(session, query, NoParams, R"([[[1];["Value11"]];[[2];["Value12"]]])");

		AssertTableReads(result, "/Root/FJ_Table_1", 2);

Added parameter selectivity and boosted LookupJoin #6874

Added parameter selectivity and boosted LookupJoin #6874

Conversation

pavelvelikhov commented Jul 19, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented Jul 19, 2024 • edited Loading

github-actions bot commented Jul 19, 2024 • edited Loading

github-actions bot commented Jul 19, 2024 • edited Loading

github-actions bot commented Jul 19, 2024 • edited Loading

github-actions bot commented Jul 19, 2024 • edited Loading

github-actions bot commented Jul 19, 2024 • edited Loading

spuchin Jul 19, 2024

Choose a reason for hiding this comment

pavelvelikhov Jul 19, 2024

Choose a reason for hiding this comment

github-actions bot commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024 •

edited

Loading