Skip to content

don't lock on zero memory change #6926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

gridnevvvit
Copy link
Member

Changelog entry

don't make a lock on zero memory change

Changelog category

  • Bugfix

Additional information

...

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 10:26:19 UTC Pre-commit check for fb88021 has started.
2024-07-22 10:28:57 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-22 10:33:57 UTC Build successful.

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 10:26:25 UTC Pre-commit check for fb88021 has started.
2024-07-22 10:29:08 UTC Build+Tests linux-x86_64-release-asan is running...
🔴 2024-07-22 10:48:09 UTC Test run completed, no test results found for commit 69333a8.
2024-07-22 10:49:11 UTC Check cancelled

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 10:26:33 UTC Pre-commit check for fb88021 has started.
2024-07-22 10:29:11 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🔴 2024-07-22 10:48:03 UTC Test run completed, no test results found for commit 69333a8.
2024-07-22 10:48:44 UTC Check cancelled

add extra counters to track calls
@gridnevvvit gridnevvvit force-pushed the dont-lock-on-zero-memory branch from 0954c12 to e8d3629 Compare July 22, 2024 10:49
Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 10:52:57 UTC Pre-commit check for e19029d has started.
2024-07-22 10:55:47 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-22 13:07:17 UTC Build successful.
🔴 2024-07-22 13:09:35 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10934 10345 0 92 328 169

🟢 2024-07-22 13:10:22 UTC ydbd size 5.2 GiB changed* by +22.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0fd2795 merge: e19029d diff diff %
ydbd size 5 556 859 008 Bytes 5 556 882 024 Bytes +22.5 KiB +0.000%
ydbd stripped size 1 196 988 848 Bytes 1 196 992 624 Bytes +3.7 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 10:53:05 UTC Pre-commit check for e19029d has started.
2024-07-22 10:55:49 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-22 11:06:59 UTC Build successful.

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 10:53:18 UTC Pre-commit check for e19029d has started.
2024-07-22 10:56:01 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-22 12:48:09 UTC Build successful.
🔴 2024-07-22 12:52:20 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39461 34218 0 5 5226 12

🟢 2024-07-22 12:53:08 UTC ydbd size 8.1 GiB changed* by +10.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0fd2795 merge: e19029d diff diff %
ydbd size 8 658 392 912 Bytes 8 658 403 696 Bytes +10.5 KiB +0.000%
ydbd stripped size 471 146 656 Bytes 471 147 680 Bytes +1.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 20:38:50 UTC Pre-commit check for 735f495 has started.
2024-07-22 20:41:43 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-22 22:38:56 UTC Build successful.
🔴 2024-07-22 22:43:23 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39605 34315 0 1 5276 13

🟡 2024-07-22 22:44:10 UTC ydbd size 8.1 GiB changed* by +155.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: eba228e merge: 735f495 diff diff %
ydbd size 8 650 062 936 Bytes 8 650 222 512 Bytes +155.8 KiB +0.002%
ydbd stripped size 470 897 152 Bytes 470 909 568 Bytes +12.1 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 20:39:18 UTC Pre-commit check for 735f495 has started.
2024-07-22 20:42:03 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-22 22:55:30 UTC Build successful.
🔴 2024-07-22 22:58:05 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10935 10341 0 89 331 174

🟡 2024-07-22 22:58:58 UTC ydbd size 5.2 GiB changed* by +109.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 70eed72 merge: 735f495 diff diff %
ydbd size 5 554 210 824 Bytes 5 554 322 824 Bytes +109.4 KiB +0.002%
ydbd stripped size 1 196 330 224 Bytes 1 196 359 536 Bytes +28.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 20:39:42 UTC Pre-commit check for 735f495 has started.
2024-07-22 20:42:34 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-22 20:52:56 UTC Build successful.

Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 11:52:44 UTC Pre-commit check for d4debde has started.
2024-07-23 11:55:28 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-23 12:10:06 UTC Build successful.

Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 11:57:12 UTC Pre-commit check for d4debde has started.
2024-07-23 11:59:55 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-23 14:05:45 UTC Build successful.
🔴 2024-07-23 14:07:33 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10938 10350 0 95 320 173

🟢 2024-07-23 14:08:23 UTC ydbd size 5.2 GiB changed* by +11.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c12733d merge: d4debde diff diff %
ydbd size 5 556 014 808 Bytes 5 556 027 032 Bytes +11.9 KiB +0.000%
ydbd stripped size 1 196 745 104 Bytes 1 196 747 216 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 20:12:19 UTC Pre-commit check for d59d8d5 has started.
2024-07-23 20:15:06 UTC Build+Tests linux-x86_64-release-clang14 is running...
🔴 2024-07-23 20:22:00 UTC Build failed. see the logs.

Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 20:12:32 UTC Pre-commit check for d59d8d5 has started.
2024-07-23 20:15:12 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🔴 2024-07-23 20:24:40 UTC Build failed. see the logs.
🔴 2024-07-23 20:24:43 UTC Test run completed, no test results found for commit eb0a2c4.

Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 20:12:38 UTC Pre-commit check for d59d8d5 has started.
2024-07-23 20:15:20 UTC Build+Tests linux-x86_64-release-asan is running...
🔴 2024-07-23 20:23:31 UTC Build failed. see the logs.
🔴 2024-07-23 20:23:34 UTC Test run completed, no test results found for commit eb0a2c4.

@gridnevvvit gridnevvvit force-pushed the dont-lock-on-zero-memory branch from eb0a2c4 to fd8197e Compare July 23, 2024 22:13
Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 22:16:44 UTC Pre-commit check for 3b648f5 has started.
2024-07-23 22:19:33 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-23 22:27:02 UTC Build successful.

Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 22:16:48 UTC Pre-commit check for 3b648f5 has started.
2024-07-23 22:19:33 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-24 00:26:33 UTC Build successful.
🔴 2024-07-24 00:28:40 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10926 10325 0 96 329 176

🟢 2024-07-24 00:29:35 UTC ydbd size 5.2 GiB changed* by -46.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 86bca72 merge: 3b648f5 diff diff %
ydbd size 5 556 159 344 Bytes 5 556 111 496 Bytes -46.7 KiB -0.001%
ydbd stripped size 1 196 798 544 Bytes 1 196 780 048 Bytes -18.1 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 23, 2024

2024-07-23 22:18:57 UTC Pre-commit check for 3b648f5 has started.
2024-07-23 22:21:49 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-24 00:14:11 UTC Build successful.
🔴 2024-07-24 00:18:29 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39618 34320 0 3 5279 16

🟢 2024-07-24 00:19:10 UTC ydbd size 8.1 GiB changed* by -279.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 86bca72 merge: 3b648f5 diff diff %
ydbd size 8 652 687 744 Bytes 8 652 401 144 Bytes -279.9 KiB -0.003%
ydbd stripped size 471 060 000 Bytes 471 052 640 Bytes -7.2 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit merged commit 4981a3b into ydb-platform:main Jul 24, 2024
8 of 12 checks passed
@gridnevvvit gridnevvvit deleted the dont-lock-on-zero-memory branch July 24, 2024 11:11
gridnevvvit added a commit to gridnevvvit/ydb that referenced this pull request Jul 24, 2024
gridnevvvit added a commit to gridnevvvit/ydb that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants