Skip to content

Rescue asan tests (remove NO_EXPORT_DYNAMIC_SYMBOLS for them) #7290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2024
Merged

Rescue asan tests (remove NO_EXPORT_DYNAMIC_SYMBOLS for them) #7290

merged 1 commit into from
Jul 31, 2024

Conversation

maximyurchuk
Copy link
Collaborator

Changelog entry

For some reason NO_EXPORT_DYNAMIC_SYMBOLS() break some asan tests.

Unfortunately I have no time to investigate it in details, so just removed NO_EXPORT_DYNAMIC_SYMBOLS() for sanitizers

Also reported in CPPCOM-32

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

@maximyurchuk maximyurchuk requested a review from gridnevvvit July 31, 2024 09:09
@maximyurchuk maximyurchuk marked this pull request as ready for review July 31, 2024 09:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

⚪ 2024-07-31 09:10:53 UTC Pre-commit check for 954b7f7 has started.
⚪ 2024-07-31 09:13:26 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-31 09:13:33 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

⚪ 2024-07-31 09:12:24 UTC Pre-commit check for 954b7f7 has started.
⚪ 2024-07-31 09:15:48 UTC Check linux-x86_64-release-asan is running...
🟢 2024-07-31 09:15:52 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-07-31 09:15:58 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

⚪ 2024-07-31 09:14:12 UTC Pre-commit check for 954b7f7 has started.
⚪ 2024-07-31 09:16:41 UTC Check linux-x86_64-relwithdebinfo is running...
🟢 2024-07-31 09:16:45 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-07-31 09:16:51 UTC Build successful.

@maximyurchuk maximyurchuk merged commit 8dde59c into ydb-platform:main Jul 31, 2024
13 checks passed
maximyurchuk added a commit to maximyurchuk/ydb that referenced this pull request Jul 31, 2024
@maximyurchuk
Rescue asan tests (remove NO_EXPORT_DYNAMIC_SYMBOLS for them) (ydb-pl…
13edd8a 
…atform#7290)
@maximyurchuk maximyurchuk mentioned this pull request Jul 31, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximyurchuk @gridnevvvit