Skip to content

Add default copy assignment operator to TVDiskAvailabilityTiming #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

hdnpth
Copy link
Collaborator

@hdnpth hdnpth commented Dec 26, 2023

Just add default copy assignment operator in order to avoid -Wdeprecated-copy warn on the upcoming libcxx update.

The implicit definition of a copy constructor as defaulted is deprecated if the class has a user-declared copy assignment operator or a user-declared destructor. The implicit definition of a copy assignment operator as defaulted is deprecated if the class has a user-declared copy constructor or a user-declared destructor.

Copy link

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@alexv-smirnov alexv-smirnov added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Dec 27, 2023
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Dec 27, 2023
Copy link

github-actions bot commented Dec 27, 2023

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-release-asan: all tests PASSED for commit 714f3aa.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 714f3aa.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59128 49922 0 19 9170 17

robot-piglet pushed a commit to ydb-platform/nbs that referenced this pull request Dec 27, 2023
@alexv-smirnov alexv-smirnov merged commit f5c9d26 into ydb-platform:main Dec 29, 2023
@StekPerepolnen StekPerepolnen mentioned this pull request Dec 29, 2023
Closed
adameat pushed a commit to adameat/ydb that referenced this pull request Dec 29, 2023
This was referenced Jan 3, 2024
This was referenced Jan 11, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants