Skip to content

Extracted yson result formatting from DQ service node #7563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 10, 2024
Merged

Extracted yson result formatting from DQ service node #7563

merged 6 commits into from
Aug 10, 2024

Conversation

vitstn
Copy link
Collaborator

@vitstn vitstn commented Aug 8, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@vitstn vitstn requested a review from a team as a code owner August 8, 2024 11:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 11:19:53 UTC Pre-commit check for d5dd0bc has started.
⚪ 2024-08-08 11:23:33 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-08 13:14:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38507 33186 0 2 5308 11

⚪ 2024-08-08 13:18:59 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-08 13:26:25 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15 (only retried tests) 7 0 0 0 8

🟢 2024-08-08 13:29:38 UTC Build successful.
🟢 2024-08-08 13:30:12 UTC ydbd size 8.1 GiB changed* by +3.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c2e177f merge: d5dd0bc diff diff %
ydbd size 8 675 878 016 Bytes 8 675 881 880 Bytes +3.8 KiB +0.000%
ydbd stripped size 472 174 664 Bytes 472 174 856 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 11:20:02 UTC Pre-commit check for d5dd0bc has started.
⚪ 2024-08-08 11:22:50 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-08 13:23:32 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9756 9714 0 6 23 13

🟢 2024-08-08 13:24:44 UTC Build successful.
🟢 2024-08-08 13:25:13 UTC ydbd size 5.4 GiB changed* by -85.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: c2e177f merge: d5dd0bc diff diff %
ydbd size 5 834 401 160 Bytes 5 834 313 384 Bytes -85.7 KiB -0.002%
ydbd stripped size 1 465 529 648 Bytes 1 465 516 816 Bytes -12.5 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 11:20:03 UTC Pre-commit check for d5dd0bc has started.
⚪ 2024-08-08 11:22:47 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-08 11:28:19 UTC Build successful.

@vitstn vitstn requested a review from a team as a code owner August 8, 2024 13:36
@vitstn vitstn requested a review from nepal August 8, 2024 13:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 13:39:45 UTC Pre-commit check for b601a6e has started.
⚪ 2024-08-08 13:43:37 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-08 16:08:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73063 59453 0 4 13594 12

⚪ 2024-08-08 16:18:50 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-08 16:26:01 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20 (only retried tests) 12 0 0 0 8

🟢 2024-08-08 16:32:43 UTC Build successful.
🟢 2024-08-08 16:33:15 UTC ydbd size 8.1 GiB changed* by +35.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f7c4264 merge: b601a6e diff diff %
ydbd size 8 676 086 720 Bytes 8 676 123 488 Bytes +35.9 KiB +0.000%
ydbd stripped size 472 184 136 Bytes 472 184 968 Bytes +832 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 13:41:04 UTC Pre-commit check for b601a6e has started.
⚪ 2024-08-08 13:45:09 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-08 14:02:59 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 13:41:36 UTC Pre-commit check for b601a6e has started.
⚪ 2024-08-08 13:44:31 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-08 16:41:46 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11568 11511 0 7 34 16

🟢 2024-08-08 16:43:04 UTC Build successful.
🟢 2024-08-08 16:43:33 UTC ydbd size 5.4 GiB changed* by -56.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f7c4264 merge: b601a6e diff diff %
ydbd size 5 834 602 216 Bytes 5 834 544 312 Bytes -56.5 KiB -0.001%
ydbd stripped size 1 465 568 016 Bytes 1 465 558 672 Bytes -9.1 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitstn vitstn changed the title Ensure no OOB before result Extracted yson result formatting from DQ service node Aug 8, 2024
@vitstn vitstn requested a review from resetius August 8, 2024 17:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 17:07:01 UTC Pre-commit check for a7f1c40 has started.
⚪ 2024-08-08 17:09:50 UTC Check linux-x86_64-release-clang14 is running...
⚫ 2024-08-08 17:29:21 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 17:07:09 UTC Pre-commit check for a7f1c40 has started.
⚪ 2024-08-08 17:10:03 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-08 17:29:28 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 17:07:14 UTC Pre-commit check for a7f1c40 has started.
⚪ 2024-08-08 17:10:05 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-08 17:29:35 UTC Check cancelled

@vitstn vitstn added the area/yql YQL query language issues label Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 17:31:03 UTC Pre-commit check for 77245c6 has started.
⚪ 2024-08-08 17:34:38 UTC Check linux-x86_64-release-clang14 is running...
⚫ 2024-08-08 17:38:46 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 17:32:49 UTC Pre-commit check for 77245c6 has started.
⚪ 2024-08-08 17:35:38 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-08 17:38:48 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 17:33:12 UTC Pre-commit check for 77245c6 has started.
⚪ 2024-08-08 17:36:08 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-08 17:38:47 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 17:41:01 UTC Pre-commit check for 8ea069d has started.
⚪ 2024-08-08 17:44:57 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-08 17:50:52 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 17:41:06 UTC Pre-commit check for 8ea069d has started.
⚪ 2024-08-08 17:43:54 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-08 19:54:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73266 59614 0 47 13592 13

⚪ 2024-08-08 20:04:02 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-08 20:15:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
63 (only retried tests) 7 0 44 1 11

⚪ 2024-08-08 20:15:45 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-08-08 20:26:53 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
56 (only retried tests) 3 0 44 0 9

🟢 2024-08-08 20:27:04 UTC Build successful.
🟡 2024-08-08 20:27:42 UTC ydbd size 8.1 GiB changed* by +120.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8f77485 merge: 8ea069d diff diff %
ydbd size 8 682 535 144 Bytes 8 682 658 568 Bytes +120.5 KiB +0.001%
ydbd stripped size 472 557 672 Bytes 472 562 920 Bytes +5.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 17:41:48 UTC Pre-commit check for 8ea069d has started.
⚪ 2024-08-08 17:44:45 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-08 20:02:07 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11775 11703 0 19 34 19

🟢 2024-08-08 20:03:32 UTC Build successful.
🟢 2024-08-08 20:04:04 UTC ydbd size 5.4 GiB changed* by -45.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8f77485 merge: 8ea069d diff diff %
ydbd size 5 839 792 744 Bytes 5 839 746 344 Bytes -45.3 KiB -0.001%
ydbd stripped size 1 467 330 960 Bytes 1 467 323 984 Bytes -6.8 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

resetius
resetius previously approved these changes Aug 8, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 13:34:21 UTC Pre-commit check for 6272bea has started.
⚪ 2024-08-09 13:37:28 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-09 14:00:28 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 13:34:29 UTC Pre-commit check for 6272bea has started.
⚪ 2024-08-09 13:37:19 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-09 16:03:20 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 13:35:15 UTC Pre-commit check for 6272bea has started.
⚪ 2024-08-09 13:39:03 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-09 16:03:20 UTC Check cancelled

@vitstn vitstn requested a review from a team as a code owner August 9, 2024 16:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 16:06:44 UTC Pre-commit check for df24027 has started.
⚪ 2024-08-09 16:10:40 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-09 16:17:07 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 16:07:08 UTC Pre-commit check for df24027 has started.
⚪ 2024-08-09 16:10:56 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-09 18:33:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73323 59706 0 3 13599 15

⚪ 2024-08-09 18:42:24 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-09 18:53:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22 (only retried tests) 8 0 2 4 8

⚪ 2024-08-09 18:53:47 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-09 19:01:12 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 6 0 0 0 8

🟢 2024-08-09 19:01:19 UTC Build successful.
🟡 2024-08-09 19:01:54 UTC ydbd size 8.1 GiB changed* by +182.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 13d5b4c merge: df24027 diff diff %
ydbd size 8 688 685 032 Bytes 8 688 871 864 Bytes +182.5 KiB +0.002%
ydbd stripped size 472 752 520 Bytes 472 757 416 Bytes +4.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 16:07:11 UTC Pre-commit check for df24027 has started.
⚪ 2024-08-09 16:10:11 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-09 18:35:15 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11772 11715 0 7 34 16

🟢 2024-08-09 18:36:38 UTC Build successful.
🟢 2024-08-09 18:37:21 UTC ydbd size 5.4 GiB changed* by -36.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 13d5b4c merge: df24027 diff diff %
ydbd size 5 843 783 352 Bytes 5 843 745 968 Bytes -36.5 KiB -0.001%
ydbd stripped size 1 468 105 872 Bytes 1 468 094 800 Bytes -10.8 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitstn vitstn enabled auto-merge (squash) August 10, 2024 07:45
@vitstn vitstn requested a review from resetius August 10, 2024 07:47
@vitstn vitstn merged commit f93ea93 into ydb-platform:main Aug 10, 2024
10 of 12 checks passed
@vitstn vitstn deleted the ensure_no_oob branch August 10, 2024 08:28
@GrigoriyPA GrigoriyPA mentioned this pull request Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nepal nepal nepal approved these changes

@uzhastik uzhastik uzhastik approved these changes

@resetius resetius Awaiting requested review from resetius

Assignees
No one assigned
Labels
area/yql YQL query language issues not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vitstn @nepal @resetius @uzhastik