Skip to content

Fix json float/double print format #7572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2024
Merged

Fix json float/double print format #7572

merged 1 commit into from
Aug 8, 2024

Conversation

dcherednik
Copy link
Member

No description provided.

@dcherednik dcherednik requested a review from a team as a code owner August 8, 2024 12:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 12:51:33 UTC Pre-commit check for 947652f has started.
⚪ 2024-08-08 12:54:20 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-08 14:53:22 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9533 9485 0 10 24 14

🟢 2024-08-08 14:55:06 UTC Build successful.
🟢 2024-08-08 14:55:34 UTC ydbd size 5.4 GiB changed* by +43.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f010ee3 merge: 947652f diff diff %
ydbd size 5 834 556 976 Bytes 5 834 601 704 Bytes +43.7 KiB +0.001%
ydbd stripped size 1 465 559 216 Bytes 1 465 571 536 Bytes +12.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 13:06:03 UTC Pre-commit check for 947652f has started.
⚪ 2024-08-08 13:09:21 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-08 13:14:58 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 13:07:37 UTC Pre-commit check for 947652f has started.
⚪ 2024-08-08 13:10:27 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-08 14:40:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13696 12345 0 2 1335 14

⚪ 2024-08-08 14:41:51 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-08 14:49:40 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17 (only retried tests) 9 0 0 0 8

🟢 2024-08-08 14:50:48 UTC Build successful.
🟢 2024-08-08 14:51:21 UTC ydbd size 8.1 GiB changed* by +99.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f010ee3 merge: 947652f diff diff %
ydbd size 8 675 982 048 Bytes 8 676 083 808 Bytes +99.4 KiB +0.001%
ydbd stripped size 472 181 896 Bytes 472 184 008 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik merged commit 8f77485 into ydb-platform:main Aug 8, 2024
10 of 13 checks passed
@GrigoriyPA GrigoriyPA mentioned this pull request Aug 13, 2024
Merged
dcherednik added a commit to dcherednik/ydb that referenced this pull request Aug 13, 2024
@dcherednik
Fix json float/double print format (ydb-platform#7572)
e40ddd6 
SELECT CAST("311111111113.222222223" as Double) should not lost precision
dcherednik added a commit to dcherednik/ydb that referenced this pull request Aug 14, 2024
@dcherednik
Fix json float/double print format (ydb-platform#7572)
ea4b4f7 
SELECT CAST("311111111113.222222223" as Double) should not lost precision
dcherednik added a commit to dcherednik/ydb that referenced this pull request Aug 14, 2024
@dcherednik
Fix json float/double print format (ydb-platform#7572)
dae932b 
SELECT CAST("311111111113.222222223" as Double) should not lost precision
dcherednik added a commit that referenced this pull request Aug 14, 2024
@dcherednik
Fix json float/double print format (#7572) (#7776)
f31bfa8
dcherednik added a commit that referenced this pull request Aug 14, 2024
@dcherednik
Fix json float/double print format (#7572) (#7779)
27ed671
@niksaveliev niksaveliev mentioned this pull request Aug 15, 2024
Closed
This was referenced Aug 23, 2024
Closed
Closed
@swalrus1 swalrus1 mentioned this pull request Sep 3, 2024
Closed
adameat pushed a commit to adameat/ydb that referenced this pull request Oct 1, 2024
@dcherednik @adameat
Fix json float/double print format (ydb-platform#7572)
f611fa4 
SELECT CAST("311111111113.222222223" as Double) should not lost precision
adameat pushed a commit to adameat/ydb that referenced this pull request Oct 4, 2024
@dcherednik @adameat
Fix json float/double print format (ydb-platform#7572)
957cb00 
SELECT CAST("311111111113.222222223" as Double) should not lost precision
This was referenced Oct 29, 2024
Closed
Closed
@serbel324 serbel324 mentioned this pull request Nov 19, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StekPerepolnen StekPerepolnen StekPerepolnen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcherednik @StekPerepolnen