Skip to content

fix query id for recompilation #7599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

VPolka
Copy link
Collaborator

@VPolka VPolka commented Aug 8, 2024

Changelog entry

Get queryIt.second' in kqp_compile_service.cpp:44 error if:

make request with user sid (it will be saved in queryId)
change table scheme
make the same request (it will be with recompilation, queryId with sid will be removed from cache and make new queryId without sid)
make the same request (it will be with sid and it doesn't find it in cache, then in cache will be 2 query Id with and without sid)
change table scheme
make the same request (it will be with recompilation, queryId with sid will be removed from cache and make new queryId without sid, then it will be compiled and try to put it in cache, but this queryId without sid is already in cache)

Changelog category

  • Bugfix

Additional information

@VPolka VPolka requested a review from a team as a code owner August 8, 2024 21:31
Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 21:34:36 UTC Pre-commit check for d1895f9 has started.
2024-08-08 21:37:03 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-08-08 22:04:19 UTC Build successful.

Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 21:34:44 UTC Pre-commit check for d1895f9 has started.
2024-08-08 21:37:14 UTC Build linux-x86_64-release-asan is running...
🟢 2024-08-08 21:59:05 UTC Build successful.
2024-08-08 21:59:50 UTC Tests are running...
🔴 2024-08-08 23:44:52 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9760 9715 0 7 26 12

🟢 2024-08-08 23:45:25 UTC ydbd size 5.5 GiB changed* by +4.0 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 72e974f merge: d1895f9 diff diff %
ydbd size 5 903 538 752 Bytes 5 903 542 800 Bytes +4.0 KiB +0.000%
ydbd stripped size 1 480 175 392 Bytes 1 480 176 096 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 21:35:00 UTC Pre-commit check for d1895f9 has started.
2024-08-08 21:37:30 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-08-08 22:15:25 UTC Build successful.
2024-08-08 22:15:42 UTC Tests are running...
🔴 2024-08-08 23:38:02 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13896 12576 0 2 1308 10

🟢 2024-08-08 23:38:42 UTC ydbd size 8.1 GiB changed* by +1.8 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 72e974f merge: d1895f9 diff diff %
ydbd size 8 722 346 880 Bytes 8 722 348 752 Bytes +1.8 KiB +0.000%
ydbd stripped size 476 893 544 Bytes 476 893 800 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants