TESTOWNERS and migration to column shard #7733
Conversation
naspirato
changed the title
|
⚪ ⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
naspirato
force-pushed
the
flaky_analytics_2
branch
from
c1d9c40 to
e9f8167
Compare
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| import urllib.parse | ||
|
|
||
| # Функция для декодирования percent-encoded строки | ||
| def decode_percent_encoded_string(encoded_string): |
There was a problem hiding this comment.
Чет непонятно зачем функция, которая перевызывает другую функцию as is
There was a problem hiding this comment.
Файл для удаления, поэтому коммент неактуален
| .add_column("branch", ydb.OptionalType(ydb.PrimitiveType.Utf8)) | ||
| .add_column("build_type", ydb.OptionalType(ydb.PrimitiveType.Utf8)) | ||
| .add_column("commit", ydb.OptionalType(ydb.PrimitiveType.Utf8)) | ||
| .add_column("duration", ydb.OptionalType(ydb.PrimitiveType.Double)) |
There was a problem hiding this comment.
Вот тут я бы предложил единицы измерения указать, типа duration_sec
There was a problem hiding this comment.
к сожалению поздно
Нынешний ydb cli не умеет при ипорте/экспорте менять название столбца (насколько я видел)
|
|
||
|
|
||
| def main(): | ||
| # parser = argparse.ArgumentParser() |
There was a problem hiding this comment.
Ну не стоит закомменченный код коммитить
| tc_settings = ydb.TableClientSettings().with_native_date_in_result_sets(enabled=True) | ||
| table_client = ydb.TableClient(driver, tc_settings) | ||
|
|
||
| #table_path = f'test_results/analytics/flaky_tests_history_{history_for_n_day}_days' |
There was a problem hiding this comment.
Тоже стоит почистить
Changelog entry
Changelog category
Additional information
...