add stats for queries with errors #7753

gridnevvvit · 2024-08-13T19:43:44Z

Changelog entry

add stats for queries with errors

Changelog category

Improvement

Additional information

...

github-actions · 2024-08-13T19:45:37Z

⚪ 2024-08-13 19:45:37 UTC Pre-commit check for 01b9a04 has started.
⚪ 2024-08-13 19:49:18 UTC Check linux-x86_64-release-clang14 is running...
⚫ 2024-08-13 20:00:43 UTC Check cancelled

github-actions · 2024-08-13T19:47:11Z

⚪ 2024-08-13 19:47:11 UTC Pre-commit check for 01b9a04 has started.
⚪ 2024-08-13 19:50:39 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-13 20:00:58 UTC Check cancelled

github-actions · 2024-08-13T19:59:28Z

⚪ 2024-08-13 19:59:28 UTC Pre-commit check for 01b9a04 has started.
⚫ 2024-08-13 20:03:19 UTC Check cancelled

github-actions · 2024-08-13T20:06:58Z

⚪ 2024-08-13 20:06:58 UTC Pre-commit check for 9b5cf26 has started.
⚪ 2024-08-13 20:10:33 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-13 20:28:43 UTC Build successful.

github-actions · 2024-08-13T20:07:07Z

⚪ 2024-08-13 20:07:07 UTC Pre-commit check for 9b5cf26 has started.
⚪ 2024-08-13 20:10:01 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-13 21:08:15 UTC Check cancelled

github-actions · 2024-08-13T20:07:25Z

⚪ 2024-08-13 20:07:25 UTC Pre-commit check for 9b5cf26 has started.
⚪ 2024-08-13 20:10:20 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-13 21:08:11 UTC Check cancelled

github-actions · 2024-08-13T21:09:24Z

⚪ 2024-08-13 21:09:24 UTC Pre-commit check for 9b5b36f has started.
⚪ 2024-08-13 21:13:29 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-13 22:32:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38644	33306	0	10	5310	18

⚪ 2024-08-13 22:40:02 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-13 22:48:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
32 (only retried tests)	15	0	6	1	10

⚪ 2024-08-13 22:49:08 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-08-13 22:57:53 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
22 (only retried tests)	7	0	5	0	10

🟢 2024-08-13 22:58:00 UTC Build successful.
🟢 2024-08-13 22:58:36 UTC ydbd size 8.1 GiB changed* by -130.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `bbad9a4`	merge: `9b5b36f`	diff	diff %
ydbd size	8 707 194 160 Bytes	8 707 060 392 Bytes	-130.6 KiB	-0.002%
ydbd stripped size	473 264 776 Bytes	473 258 440 Bytes	-6.2 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-08-13T21:11:35Z

⚪ 2024-08-13 21:11:35 UTC Pre-commit check for 9b5b36f has started.
⚪ 2024-08-13 21:14:15 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-13 21:19:48 UTC Build successful.

github-actions · 2024-08-13T21:12:21Z

⚪ 2024-08-13 21:12:20 UTC Pre-commit check for 9b5b36f has started.
⚪ 2024-08-13 21:15:23 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-13 23:27:04 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9834	9782	0	17	22	13

🟢 2024-08-13 23:28:13 UTC Build successful.
🟢 2024-08-13 23:28:42 UTC ydbd size 5.5 GiB changed* by -81.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `bbad9a4`	merge: `9b5b36f`	diff	diff %
ydbd size	5 855 125 352 Bytes	5 855 042 096 Bytes	-81.3 KiB	-0.001%
ydbd stripped size	1 470 036 208 Bytes	1 470 024 816 Bytes	-11.1 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-08-14T10:30:12Z

⚪ 2024-08-14 10:30:11 UTC Pre-commit check for 1438ca0 has started.
⚪ 2024-08-14 10:33:20 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-14 10:39:19 UTC Build successful.

github-actions · 2024-08-14T10:30:56Z

⚪ 2024-08-14 10:30:56 UTC Pre-commit check for 1438ca0 has started.
⚪ 2024-08-14 10:35:02 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-14 11:50:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38666	33321	0	1	5311	33

⚪ 2024-08-14 11:55:22 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-14 12:03:06 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
50 (only retried tests)	20	0	0	1	29

🟢 2024-08-14 12:03:14 UTC Build successful.
🟢 2024-08-14 12:03:52 UTC ydbd size 8.1 GiB changed* by -130.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `9ec6f05`	merge: `1438ca0`	diff	diff %
ydbd size	8 725 240 488 Bytes	8 725 107 168 Bytes	-130.2 KiB	-0.002%
ydbd stripped size	474 249 384 Bytes	474 243 112 Bytes	-6.1 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-08-14T10:32:07Z

⚪ 2024-08-14 10:32:06 UTC Pre-commit check for 1438ca0 has started.
⚪ 2024-08-14 10:37:13 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-14 12:51:20 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9845	9763	0	19	30	33

🟢 2024-08-14 12:52:32 UTC Build successful.
🟢 2024-08-14 12:53:01 UTC ydbd size 5.5 GiB changed* by -81.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `9ec6f05`	merge: `1438ca0`	diff	diff %
ydbd size	5 869 832 728 Bytes	5 869 749 696 Bytes	-81.1 KiB	-0.001%
ydbd stripped size	1 473 498 096 Bytes	1 473 486 704 Bytes	-11.1 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

abyss7 · 2024-08-14T11:51:50Z

ydb/core/kqp/executer_actor/kqp_planner.cpp

+        return true;
+    }
+
+    return false;


Unreachable?

abyss7 · 2024-08-14T11:54:05Z

ydb/core/kqp/executer_actor/kqp_planner.cpp

+void TKqpPlanner::CompletedCA(ui64 taskId, TActorId computeActor) {
+    auto& task = TasksGraph.GetTask(taskId);
+    if (task.Meta.Completed) {
+        return;


Предлагаю проверить здесь инвариант YQL_ENSURE(!PendingComputeActors.contains(computeActor))

abyss7 · 2024-08-14T11:57:53Z

ydb/core/kqp/session_actor/kqp_session_actor.cpp

@@ -352,8 +352,9 @@ class TKqpSessionActor : public TActorBootstrapped<TKqpSessionActor> {
            auto abortEv = TEvKqp::TEvAbortExecution::Aborted("Client lost"); // any status code can be here

            Send(ExecuterId, abortEv.Release());
+        } else {
+            Cleanup();


В случае bool(ExecuterId) == true когда теперь будет Cleanup()?

когда executer ответит.

github-actions · 2024-08-14T17:28:37Z

⚪ 2024-08-14 17:28:37 UTC Pre-commit check for 0d78db4 has started.
⚪ 2024-08-14 17:31:27 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-14 17:38:04 UTC Build successful.

github-actions · 2024-08-14T17:28:45Z

⚪ 2024-08-14 17:28:45 UTC Pre-commit check for 0d78db4 has started.
⚪ 2024-08-14 17:33:16 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-14 18:53:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38670	33312	0	8	5313	37

⚪ 2024-08-14 18:56:25 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-14 19:04:15 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
61 (only retried tests)	32	0	0	0	29

🟢 2024-08-14 19:04:23 UTC Build successful.
🟢 2024-08-14 19:05:01 UTC ydbd size 8.1 GiB changed* by -125.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `d1f17fc`	merge: `0d78db4`	diff	diff %
ydbd size	8 725 277 360 Bytes	8 725 148 928 Bytes	-125.4 KiB	-0.001%
ydbd stripped size	474 264 744 Bytes	474 258 920 Bytes	-5.7 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-08-14T17:28:59Z

⚪ 2024-08-14 17:28:59 UTC Pre-commit check for 0d78db4 has started.
⚪ 2024-08-14 17:31:51 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-14 19:49:52 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9848	9780	0	11	23	34

🟢 2024-08-14 19:50:44 UTC Build successful.
🟢 2024-08-14 19:51:11 UTC ydbd size 5.5 GiB changed* by -80.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `d1f17fc`	merge: `0d78db4`	diff	diff %
ydbd size	5 870 053 232 Bytes	5 869 971 056 Bytes	-80.2 KiB	-0.001%
ydbd stripped size	1 473 573 968 Bytes	1 473 559 632 Bytes	-14.0 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

(cherry picked from commit 93998b8)

github-actions bot added the improvement label Aug 13, 2024

gridnevvvit force-pushed the work-on-stats branch from 061aaa3 to 425cf0a Compare August 13, 2024 20:00

gridnevvvit force-pushed the work-on-stats branch from 425cf0a to 203b76e Compare August 13, 2024 21:07

gridnevvvit force-pushed the work-on-stats branch from 203b76e to 4ac253e Compare August 14, 2024 10:28

abyss7 reviewed Aug 14, 2024

View reviewed changes

ydb/core/kqp/executer_actor/kqp_planner.cpp

return true;

}

return false;

Copy link

Collaborator

abyss7 Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreachable?

abyss7 reviewed Aug 14, 2024

View reviewed changes

add stats for queries with errors

0790396

gridnevvvit force-pushed the work-on-stats branch from 4ac253e to 0790396 Compare August 14, 2024 17:25

abyss7 approved these changes Aug 15, 2024

View reviewed changes

abyss7 merged commit 93998b8 into ydb-platform:main Aug 15, 2024
10 of 12 checks passed

This was referenced Aug 15, 2024

YQ kqprun pass allow local files into runtime listing #7844

Merged

YQ change code owners for clickhouse/client #7898

Merged

YQ-3154 improve error in s3 applicator actor #7976

Merged

YQ-3566 fix sql injection in create binding request #7984

Merged

This was referenced Aug 19, 2024

YQ-3570 added s3 wildcards validations #8017

Merged

YQ-3568 fix error sent large get operation #8035

Merged

YQ-3363 fix internal error for insert without params #8074

Merged

YQ kqprun enable runtime listing by default #8096

Merged

stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024

add stats for queries with errors (ydb-platform#7753)

6a287e8

gridnevvvit deleted the work-on-stats branch August 30, 2024 13:48

abyss7 pushed a commit to abyss7/ydb that referenced this pull request Sep 9, 2024

add stats for queries with errors (ydb-platform#7753)

7ad55b3

(cherry picked from commit 93998b8)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add stats for queries with errors #7753

add stats for queries with errors #7753

gridnevvvit commented Aug 13, 2024

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

abyss7 Aug 14, 2024

abyss7 Aug 14, 2024

abyss7 Aug 14, 2024 •

edited

Loading

gridnevvvit Aug 14, 2024

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

add stats for queries with errors #7753

add stats for queries with errors #7753

Conversation

gridnevvvit commented Aug 13, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented Aug 13, 2024 • edited Loading

github-actions bot commented Aug 13, 2024 • edited Loading

github-actions bot commented Aug 13, 2024 • edited Loading

github-actions bot commented Aug 13, 2024 • edited Loading

github-actions bot commented Aug 13, 2024 • edited Loading

github-actions bot commented Aug 13, 2024 • edited Loading

github-actions bot commented Aug 13, 2024 • edited Loading

github-actions bot commented Aug 13, 2024 • edited Loading

github-actions bot commented Aug 13, 2024 • edited Loading

github-actions bot commented Aug 14, 2024 • edited Loading

github-actions bot commented Aug 14, 2024 • edited Loading

github-actions bot commented Aug 14, 2024 • edited Loading

abyss7 Aug 14, 2024

Choose a reason for hiding this comment

abyss7 Aug 14, 2024

Choose a reason for hiding this comment

abyss7 Aug 14, 2024 • edited Loading

Choose a reason for hiding this comment

gridnevvvit Aug 14, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 14, 2024 • edited Loading

github-actions bot commented Aug 14, 2024 • edited Loading

github-actions bot commented Aug 14, 2024 • edited Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

abyss7 Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading