Skip to content

Config option for node registration token #7754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

UgnineSirdis
Copy link
Collaborator

@UgnineSirdis UgnineSirdis commented Aug 13, 2024

Changelog entry

Config option for dynamic node registration token.
Like config option StaffApiUserToken for CMS request.

Changelog category

  • New feature

Additional information

...

Copy link

github-actions bot commented Aug 13, 2024

2024-08-13 20:24:27 UTC Pre-commit check for c188871 has started.
2024-08-13 20:27:27 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-13 21:02:00 UTC Build successful.

Copy link

github-actions bot commented Aug 13, 2024

2024-08-13 20:25:54 UTC Pre-commit check for c188871 has started.
2024-08-13 20:29:03 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-13 23:15:43 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11137 11073 0 22 25 17

🟢 2024-08-13 23:17:02 UTC Build successful.
🟢 2024-08-13 23:17:32 UTC ydbd size 5.5 GiB changed* by +17.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1130be0 merge: c188871 diff diff %
ydbd size 5 855 124 040 Bytes 5 855 141 616 Bytes +17.2 KiB +0.000%
ydbd stripped size 1 470 037 808 Bytes 1 470 044 656 Bytes +6.7 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 13, 2024

2024-08-13 20:26:53 UTC Pre-commit check for c188871 has started.
2024-08-13 20:30:44 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-13 22:13:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39960 34634 0 1 5310 15

2024-08-13 22:19:16 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-13 22:27:19 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19 (only retried tests) 9 0 0 0 10

🟢 2024-08-13 22:27:27 UTC Build successful.
🟢 2024-08-13 22:28:06 UTC ydbd size 8.1 GiB changed* by +13.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1130be0 merge: c188871 diff diff %
ydbd size 8 707 197 048 Bytes 8 707 210 624 Bytes +13.3 KiB +0.000%
ydbd stripped size 473 265 352 Bytes 473 266 280 Bytes +928 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@@ -55,6 +55,7 @@ message TAuthConfig {
optional string AccessServiceType = 79 [default = "Yandex_v2"]; // For now the following values are supported: "Yandex_v2", "Nebius_v1"
optional string CertificateAuthenticationDomain = 80 [default = "cert"];
optional bool EnableLoginAuthentication = 81 [default = true];
optional string NodeRegistrationToken = 82 [default = "root@builtin", (Ydb.sensitive) = true];
Copy link
Collaborator

@ijon ijon Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have made a comment about how it is better to not shove default values into the protobuf specs (for a number of reasons), but... having seen the entire message spec I think its too late.

@UgnineSirdis UgnineSirdis merged commit 0ce24a5 into ydb-platform:main Aug 15, 2024
13 of 15 checks passed
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Aug 16, 2024
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Aug 19, 2024
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Sep 17, 2024
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants