-
Notifications
You must be signed in to change notification settings - Fork 646
Config option for node registration token #7754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config option for node registration token #7754
Conversation
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
@@ -55,6 +55,7 @@ message TAuthConfig { | |||
optional string AccessServiceType = 79 [default = "Yandex_v2"]; // For now the following values are supported: "Yandex_v2", "Nebius_v1" | |||
optional string CertificateAuthenticationDomain = 80 [default = "cert"]; | |||
optional bool EnableLoginAuthentication = 81 [default = true]; | |||
optional string NodeRegistrationToken = 82 [default = "root@builtin", (Ydb.sensitive) = true]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have made a comment about how it is better to not shove default values into the protobuf specs (for a number of reasons), but... having seen the entire message spec I think its too late.
(cherry picked from commit 0ce24a5)
(cherry picked from commit 0ce24a5)
(cherry picked from commit 0ce24a5)
(cherry picked from commit 0ce24a5)
Changelog entry
Config option for dynamic node registration token.
Like config option
StaffApiUserToken
for CMS request.Changelog category
Additional information
...