Skip to content

fix columns normalization for absent (#7340) #7764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix columns normalization for absent (#7340) #7764

wants to merge 3 commits into from

Conversation

zverevgeny
Copy link
Collaborator

@zverevgeny zverevgeny commented Aug 14, 2024 •
edited
Loading

intergrate #7340 from main

@zverevgeny zverevgeny requested a review from a team as a code owner August 14, 2024 08:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 08:16:26 UTC Pre-commit check for 6de71a3 has started.
⚪ 2024-08-14 08:19:04 UTC Build linux-x86_64-release-asan is running...
🔴 2024-08-14 08:21:36 UTC Build failed. see the build logs.
🔴 2024-08-14 08:21:37 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 08:18:06 UTC Pre-commit check for 6de71a3 has started.
⚪ 2024-08-14 08:20:38 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-08-14 08:23:18 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 08:18:35 UTC Pre-commit check for 6de71a3 has started.
⚪ 2024-08-14 08:21:07 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-08-14 08:23:54 UTC Build failed. see the build logs.
🔴 2024-08-14 08:23:55 UTC Tests run skipped.

@ivanmorozov333 @zverevgeny
fix columns normalization for absent (ydb-platform#7340)
d0e5d85 
 Conflicts:
	ydb/core/kqp/ut/olap/kqp_olap_ut.cpp
	ydb/core/tx/columnshard/engines/changes/compaction/merger.cpp
@ivanmorozov333 @zverevgeny
fix empty column usage (ydb-platform#7334)
21930cf 
 Conflicts:
	ydb/core/kqp/ut/olap/kqp_olap_ut.cpp
	ydb/core/tx/columnshard/engines/scheme/versions/abstract_scheme.cpp
@zverevgeny zverevgeny force-pushed the tests_and_fixes_columns_normalization branch from 1c29350 to 21930cf Compare August 15, 2024 06:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 06:50:49 UTC Pre-commit check for 5f80699 has started.
⚪ 2024-08-15 06:53:21 UTC Build linux-x86_64-release-asan is running...
🔴 2024-08-15 07:01:26 UTC Build failed. see the build logs.
🔴 2024-08-15 07:01:27 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 06:51:07 UTC Pre-commit check for 5f80699 has started.
⚪ 2024-08-15 06:53:50 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-08-15 07:05:01 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 06:51:41 UTC Pre-commit check for 5f80699 has started.
⚪ 2024-08-15 06:54:20 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-08-15 07:03:55 UTC Build failed. see the build logs.
🔴 2024-08-15 07:03:56 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 07:14:11 UTC Pre-commit check for b1a5e61 has started.
⚪ 2024-08-15 07:16:43 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-08-15 07:22:49 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 07:14:15 UTC Pre-commit check for b1a5e61 has started.
⚪ 2024-08-15 07:16:56 UTC Build linux-x86_64-release-asan is running...
🟢 2024-08-15 07:40:53 UTC Build successful.
⚪ 2024-08-15 07:41:10 UTC Tests are running...
🔴 2024-08-15 10:39:59 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10005 9964 0 5 25 11

🟡 2024-08-15 10:40:38 UTC ydbd size 5.5 GiB changed* by +137.8 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: f31bfa8 merge: b1a5e61 diff diff %
ydbd size 5 904 422 904 Bytes 5 904 563 992 Bytes +137.8 KiB +0.002%
ydbd stripped size 1 480 270 368 Bytes 1 480 280 704 Bytes +10.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 07:14:25 UTC Pre-commit check for b1a5e61 has started.
⚪ 2024-08-15 07:17:06 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-08-15 07:55:35 UTC Build successful.
⚪ 2024-08-15 07:55:50 UTC Tests are running...
🔴 2024-08-15 10:01:19 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38534 33308 0 2 5214 10

🟡 2024-08-15 10:04:10 UTC ydbd size 8.1 GiB changed* by +331.8 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: f31bfa8 merge: b1a5e61 diff diff %
ydbd size 8 723 960 728 Bytes 8 724 300 536 Bytes +331.8 KiB +0.004%
ydbd stripped size 476 914 184 Bytes 476 915 208 Bytes +1.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanmorozov333 ivanmorozov333 Awaiting requested review from ivanmorozov333

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zverevgeny @ivanmorozov333