Skip to content

Statistics: Two force traversal collections in local DB #7765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 15, 2024
Merged

Statistics: Two force traversal collections in local DB #7765

merged 3 commits into from
Aug 15, 2024

Conversation

azevaykin
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 08:31:28 UTC Pre-commit check for a9b6e74 has started.
⚪ 2024-08-14 08:34:30 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-14 11:01:43 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9590 9519 0 12 25 34

🟢 2024-08-14 11:02:51 UTC Build successful.
🔴 2024-08-14 11:03:19 UTC ydbd size 5.5 GiB changed* by +14.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: cf8dbc3 merge: a9b6e74 diff diff %
ydbd size 5 855 110 912 Bytes 5 870 117 480 Bytes +14.3 MiB +0.256%
ydbd stripped size 1 470 033 136 Bytes 1 473 553 392 Bytes +3.4 MiB +0.239%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-15 08:55:38 UTC Pre-commit check for a9b6e74 has started.
⚪ 2024-08-15 08:58:16 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-15 09:03:28 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 08:33:01 UTC Pre-commit check for a9b6e74 has started.
⚪ 2024-08-14 08:35:40 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-14 10:00:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13783 12412 0 1 1336 34

⚪ 2024-08-14 10:02:27 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-14 10:09:35 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
49 (only retried tests) 21 0 0 0 28

🟢 2024-08-14 10:09:43 UTC Build successful.
🔴 2024-08-14 10:10:20 UTC ydbd size 8.1 GiB changed* by +17.6 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: cf8dbc3 merge: a9b6e74 diff diff %
ydbd size 8 707 304 056 Bytes 8 725 717 008 Bytes +17.6 MiB +0.211%
ydbd stripped size 473 262 024 Bytes 474 265 064 Bytes +979.5 KiB +0.212%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin requested review from alexd65536 and snaury August 15, 2024 08:33
@azevaykin azevaykin changed the title Statistics: Two force traversal collections Statistics: Two force traversal collections in local DB Aug 15, 2024
snaury
snaury reviewed Aug 15, 2024
View reviewed changes
snaury
snaury reviewed Aug 15, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 10:01:48 UTC Pre-commit check for 999638f has started.
⚪ 2024-08-15 10:04:32 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-15 10:10:52 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 10:02:21 UTC Pre-commit check for 999638f has started.
⚪ 2024-08-15 10:05:50 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-15 10:49:06 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 10:13:19 UTC Pre-commit check for 999638f has started.
⚪ 2024-08-15 10:15:56 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-15 10:49:07 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 10:53:21 UTC Pre-commit check for 75bf4e4 has started.
⚪ 2024-08-15 10:56:18 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-15 13:28:48 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9574 9494 0 22 24 34

🟢 2024-08-15 13:29:38 UTC Build successful.
🟡 2024-08-15 13:30:10 UTC ydbd size 5.5 GiB changed* by +365.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c26bd91 merge: 75bf4e4 diff diff %
ydbd size 5 877 755 344 Bytes 5 878 129 392 Bytes +365.3 KiB +0.006%
ydbd stripped size 1 476 699 760 Bytes 1 476 786 640 Bytes +84.8 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 10:53:21 UTC Pre-commit check for 75bf4e4 has started.
⚪ 2024-08-15 10:56:20 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-15 13:27:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13782 12411 0 3 1336 32

⚪ 2024-08-15 13:28:20 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-15 13:38:13 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
48 (only retried tests) 19 0 0 0 29

🟢 2024-08-15 13:38:21 UTC Build successful.
🟡 2024-08-15 13:38:53 UTC ydbd size 8.1 GiB changed* by +475.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1d65019 merge: 75bf4e4 diff diff %
ydbd size 8 731 836 008 Bytes 8 732 322 640 Bytes +475.2 KiB +0.006%
ydbd stripped size 475 256 104 Bytes 475 272 488 Bytes +16.0 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 10:55:02 UTC Pre-commit check for 75bf4e4 has started.
⚪ 2024-08-15 10:57:55 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-15 11:24:53 UTC Build successful.

snaury
snaury approved these changes Aug 15, 2024
View reviewed changes
ydb/core/statistics/aggregator/aggregator_impl.cpp
}

TStatisticsAggregator::TForceTraversalOperation* TStatisticsAggregator::ForceTraversalOperation(const TString& operationId) {
auto forceTraversalOperation = std::find_if(ForceTraversals.begin(), ForceTraversals.end(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В будущем было бы неплохо сделать хеш-таблицу чтобы не делать линейный поиск.

@azevaykin azevaykin merged commit d24978e into ydb-platform:main Aug 15, 2024
10 of 12 checks passed
This was referenced Aug 15, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@azevaykin azevaykin deleted the TwoForceTraversalTables branch August 23, 2024 14:39
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
@azevaykin @stanislav-shchetinin
Statistics: Two force traversal collections in local DB (ydb-platform…
99ac77b 
…#7765)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snaury snaury snaury approved these changes

@alexd65536 alexd65536 Awaiting requested review from alexd65536

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azevaykin @snaury