Wait for all CAs inside Executer before shutdown #7829
Conversation
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
abyss7
added
the
rebase-and-check
github-actions
bot
removed
the
rebase-and-check
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| LOG_I("aborting compute actor execution, message: " << issues.ToOneLineString() | ||
| << ", compute actor: " << task.ComputeActorId << ", task: " << task.Id); | ||
|
|
||
| auto ev = MakeHolder<TEvKqp::TEvAbortExecution>(NYql::NDq::YdbStatusToDqStatus(code), issues); | ||
| this->Send(task.ComputeActorId, ev.Release()); | ||
| } else { | ||
| LOG_I("task: " << task.Id << ", does not have Compute ActorId yet"); | ||
| LOG_I("task: " << task.Id << ", does not have the CA id yet or is already complete"); |
There was a problem hiding this comment.
Maybe we can add checks here also and write more explicit message, is it already completed or CA id is not known.
| runtime.SetObserverFunc([&](TAutoPtr<IEventHandle>& ev) { | ||
| if (ev->GetTypeRewrite() == NYql::NDq::TEvDqCompute::TEvState::EventType) { | ||
| ++totalEvState; | ||
| if (!firstEvState) { |
There was a problem hiding this comment.
Based on test description I would expect that firstEvState is true and after this event it becomes false.
There was a problem hiding this comment.
Probably the variable name is too vague - firstEvState indicates if we already encountered the first event State, so we replace only the first one.
(cherry picked from commit fe50fe3)
Changelog entry
Implement additional state for TKqpDataExecuter in which it will wait for all children Compute Actors for graceful shutdown.
Also Executer will respect node disconnects and timeouts - to not hang on waiting forever.
Changelog category