Skip to content

return implicit query params type into feature flag #8065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

VPolka
Copy link
Collaborator

@VPolka VPolka commented Aug 20, 2024

Changelog entry

needed for compatibility

Changelog category

  • Bugfix

Additional information

...

Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 18:04:10 UTC Pre-commit check for e156821 has started.
2024-08-20 18:04:48 UTC Check cancelled

@VPolka VPolka force-pushed the fix-implicit-params-flag branch from 453f95b to b01212b Compare August 20, 2024 18:04
Copy link

2024-08-20 18:04:36 UTC Check cancelled

Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 18:11:12 UTC Pre-commit check for f703e23 has started.
2024-08-20 18:14:17 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-20 20:03:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40439 35087 0 10 5325 17

2024-08-20 20:07:20 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-20 20:16:00 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37 (only retried tests) 27 0 0 1 9

🟢 2024-08-20 20:16:08 UTC Build successful.
🟢 2024-08-20 20:16:45 UTC ydbd size 8.1 GiB changed* by +6.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5a3ebee merge: f703e23 diff diff %
ydbd size 8 748 339 208 Bytes 8 748 346 144 Bytes +6.8 KiB +0.000%
ydbd stripped size 475 821 512 Bytes 475 822 088 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 18:11:22 UTC Pre-commit check for f703e23 has started.
2024-08-20 18:14:32 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-20 20:10:56 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11347 11283 0 20 24 20

🟢 2024-08-20 20:11:55 UTC Build successful.
🟢 2024-08-20 20:12:26 UTC ydbd size 5.5 GiB changed* by +5.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5a3ebee merge: f703e23 diff diff %
ydbd size 5 887 703 840 Bytes 5 887 709 344 Bytes +5.4 KiB +0.000%
ydbd stripped size 1 478 443 312 Bytes 1 478 444 976 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 18:11:34 UTC Pre-commit check for f703e23 has started.
2024-08-20 18:14:55 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-20 18:58:46 UTC Build successful.

@VPolka VPolka merged commit 4b0313d into ydb-platform:main Aug 21, 2024
10 of 12 checks passed
rekby pushed a commit to rekby-forks/ydb that referenced this pull request Aug 28, 2024
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
qrort added a commit that referenced this pull request Dec 31, 2024
qrort added a commit that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants