Skip to content

Enable DROP VIEW from a folder, bugfix #8066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Aug 20, 2024

KIKIMR-21808
#8067

It turned out during view testing that a basic query like:

DROP VIEW `some_folder/view`;

produces an error:

Click me
Status: GENERIC_ERROR
Issues: 
<main>: Error: <main>: Error: Check failed: path: '/Root/dedicated/some_folder/view', error: path hasn't been resolved,   nearest resolved path: '/Root/dedicated' (id: [OwnerId: 72075186224037889, LocalPathId: 1]), code: 2003

Bug is caused by the wrong path splitting in drop view operations. Previously a path like:

/Root/some_database/some_folder/view

was split into:

  • working dir: /Root/some_database
  • name: some_folder/view

parts which is wrong by SchemeShard's standards. To fix it, I split the path into:

  • working dir: /Root/some_database/some_folder
  • name: view

parts.

Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 19:44:57 UTC Pre-commit check for 52822fe has started.
2024-08-20 19:47:49 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-20 19:54:03 UTC Build successful.

Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 19:45:13 UTC Pre-commit check for 52822fe has started.
2024-08-20 19:47:58 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-20 21:31:02 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9875 9782 0 34 33 26

🟢 2024-08-20 21:31:57 UTC Build successful.
🟢 2024-08-20 21:32:29 UTC ydbd size 5.5 GiB changed* by +4.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5a3ebee merge: 52822fe diff diff %
ydbd size 5 887 703 840 Bytes 5 887 708 080 Bytes +4.1 KiB +0.000%
ydbd stripped size 1 478 443 312 Bytes 1 478 444 016 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 19:45:24 UTC Pre-commit check for 52822fe has started.
2024-08-20 19:48:04 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-20 21:29:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14281 12914 0 4 1341 22

2024-08-20 21:31:07 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-20 21:38:32 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26 (only retried tests) 17 0 0 0 9

🟢 2024-08-20 21:38:39 UTC Build successful.
🟢 2024-08-20 21:39:11 UTC ydbd size 8.1 GiB changed* by +1.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5a3ebee merge: 52822fe diff diff %
ydbd size 8 748 339 208 Bytes 8 748 340 904 Bytes +1.7 KiB +0.000%
ydbd stripped size 475 821 512 Bytes 475 821 768 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@jepett0 jepett0 requested a review from ijon August 20, 2024 20:02
@jepett0 jepett0 marked this pull request as ready for review August 21, 2024 07:14
@jepett0 jepett0 merged commit f3013a5 into ydb-platform:main Aug 21, 2024
14 of 16 checks passed
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants