Skip to content

treat initial vdisk status as ok #8150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

vporyadke
Copy link
Collaborator

Changelog entry

treat initial vdisk status as ok in healthcheck

Changelog category

  • Bugfix

Additional information

BSC used to be able to return Initial status on dead disks, this is no longer the case

Copy link

github-actions bot commented Aug 22, 2024

2024-08-22 11:15:09 UTC Pre-commit check for 69719a1 has started.
2024-08-22 11:17:50 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-22 13:02:26 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9951 9883 0 24 28 16

🟢 2024-08-22 13:03:20 UTC Build successful.
🟡 2024-08-22 13:03:49 UTC ydbd size 5.5 GiB changed* by +253.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a4003fe merge: 69719a1 diff diff %
ydbd size 5 889 514 744 Bytes 5 889 774 024 Bytes +253.2 KiB +0.004%
ydbd stripped size 1 478 895 920 Bytes 1 478 948 112 Bytes +51.0 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 22, 2024

2024-08-22 11:22:43 UTC Pre-commit check for 69719a1 has started.
2024-08-22 11:26:41 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-22 12:01:14 UTC Build successful.

Copy link

github-actions bot commented Aug 22, 2024

2024-08-22 11:26:33 UTC Pre-commit check for 69719a1 has started.
2024-08-22 11:29:26 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-22 12:55:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14520 13151 0 8 1343 18

2024-08-22 12:57:20 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-22 13:07:21 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28 (only retried tests) 20 0 0 0 8

🟢 2024-08-22 13:07:28 UTC Build successful.
🟡 2024-08-22 13:08:02 UTC ydbd size 8.2 GiB changed* by +452.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 531e359 merge: 69719a1 diff diff %
ydbd size 8 750 779 872 Bytes 8 751 242 672 Bytes +452.0 KiB +0.005%
ydbd stripped size 475 951 080 Bytes 475 960 328 Bytes +9.0 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke requested a review from ijon August 22, 2024 13:12
@vporyadke vporyadke merged commit c5366d7 into ydb-platform:main Aug 22, 2024
11 of 13 checks passed
rekby pushed a commit to rekby-forks/ydb that referenced this pull request Aug 28, 2024
@ijon ijon linked an issue Aug 29, 2024 that may be closed by this pull request
vporyadke added a commit to vporyadke/ydb that referenced this pull request Aug 29, 2024
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Healthcheck falses for storage_dead check on 24-3
2 participants