Skip to content

Support of functions with lang=sql #8233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 27, 2024
Merged

Support of functions with lang=sql #8233

merged 3 commits into from
Aug 27, 2024

Conversation

vitstn
Copy link
Collaborator

@vitstn vitstn commented Aug 24, 2024

Changelog entry

...

Changelog category

  • New feature

Additional information

...

@vitstn vitstn requested a review from a team as a code owner August 24, 2024 00:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 24, 2024 •
edited
Loading

⚪ 2024-08-24 00:52:21 UTC Pre-commit check for 4a84a7b has started.
⚪ 2024-08-24 00:55:31 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-24 01:31:00 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 24, 2024 •
edited
Loading

⚪ 2024-08-24 00:52:25 UTC Pre-commit check for 4a84a7b has started.
⚪ 2024-08-24 00:55:32 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-24 02:28:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77678 63943 0 24 13683 28

⚪ 2024-08-24 02:35:59 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-24 02:47:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
47 (only retried tests) 30 0 7 0 10

⚪ 2024-08-24 02:47:19 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-08-24 02:54:18 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21 (only retried tests) 6 0 6 0 9

🟢 2024-08-24 02:54:25 UTC Build successful.
🟡 2024-08-24 02:55:00 UTC ydbd size 8.2 GiB changed* by +533.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 92ff6c1 merge: 4a84a7b diff diff %
ydbd size 8 784 784 440 Bytes 8 785 331 048 Bytes +533.8 KiB +0.006%
ydbd stripped size 479 498 440 Bytes 479 533 192 Bytes +33.9 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 24, 2024 •
edited
Loading

⚪ 2024-08-24 00:52:37 UTC Pre-commit check for 4a84a7b has started.
⚪ 2024-08-24 00:55:52 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-24 02:55:12 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15622 15519 0 33 49 21

🟢 2024-08-24 02:56:30 UTC Build successful.
🟡 2024-08-24 02:57:00 UTC ydbd size 5.5 GiB changed* by +307.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 92ff6c1 merge: 4a84a7b diff diff %
ydbd size 5 918 942 800 Bytes 5 919 257 520 Bytes +307.3 KiB +0.005%
ydbd stripped size 1 487 376 880 Bytes 1 487 463 120 Bytes +84.2 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 24, 2024 •
edited
Loading

⚪ 2024-08-24 08:30:10 UTC Pre-commit check for 31fb356 has started.
⚪ 2024-08-24 08:33:17 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-24 10:14:27 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15623 15522 0 34 48 19

🟢 2024-08-24 10:15:45 UTC Build successful.
🟡 2024-08-24 10:16:18 UTC ydbd size 5.5 GiB changed* by +303.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b5dba78 merge: 31fb356 diff diff %
ydbd size 5 919 113 664 Bytes 5 919 424 232 Bytes +303.3 KiB +0.005%
ydbd stripped size 1 487 402 544 Bytes 1 487 484 624 Bytes +80.2 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 24, 2024 •
edited
Loading

⚪ 2024-08-24 08:30:11 UTC Pre-commit check for 31fb356 has started.
⚪ 2024-08-24 08:33:26 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-24 08:48:48 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 24, 2024 •
edited
Loading

⚪ 2024-08-24 08:31:18 UTC Pre-commit check for 31fb356 has started.
⚪ 2024-08-24 08:34:20 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-24 09:51:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77672 63964 0 6 13680 22

⚪ 2024-08-24 09:59:15 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-24 10:09:11 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
24 (only retried tests) 15 0 0 0 9

🟢 2024-08-24 10:09:18 UTC Build successful.
🟡 2024-08-24 10:09:53 UTC ydbd size 8.2 GiB changed* by +506.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 92ff6c1 merge: 31fb356 diff diff %
ydbd size 8 784 784 440 Bytes 8 785 303 416 Bytes +506.8 KiB +0.006%
ydbd stripped size 479 498 440 Bytes 479 419 016 Bytes -77.6 KiB -0.017%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitstn vitstn enabled auto-merge (squash) August 24, 2024 10:51
@vitstn vitstn added area/yql YQL query language issues area/pg labels Aug 24, 2024
@vitstn vitstn requested review from nepal and igormunkin August 24, 2024 10:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 24, 2024 •
edited
Loading

⚪ 2024-08-24 10:54:23 UTC Pre-commit check for 7d8725a has started.
⚪ 2024-08-24 10:57:43 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-24 11:04:22 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 24, 2024 •
edited
Loading

⚪ 2024-08-24 10:54:39 UTC Pre-commit check for 7d8725a has started.
⚪ 2024-08-24 10:57:53 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-24 12:36:49 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15627 15511 0 37 55 24

🟢 2024-08-24 12:38:13 UTC Build successful.
🟡 2024-08-24 12:38:42 UTC ydbd size 5.5 GiB changed* by +304.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b5dba78 merge: 7d8725a diff diff %
ydbd size 5 919 113 664 Bytes 5 919 425 016 Bytes +304.1 KiB +0.005%
ydbd stripped size 1 487 402 544 Bytes 1 487 485 168 Bytes +80.7 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 24, 2024 •
edited
Loading

⚪ 2024-08-24 10:55:04 UTC Pre-commit check for 7d8725a has started.
⚪ 2024-08-24 10:58:22 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-24 12:22:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77673 63966 0 6 13680 21

⚪ 2024-08-24 12:30:12 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-24 12:38:52 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
24 (only retried tests) 14 0 0 0 10

🟢 2024-08-24 12:38:59 UTC Build successful.
🟡 2024-08-24 12:39:36 UTC ydbd size 8.2 GiB changed* by +507.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 92ff6c1 merge: 7d8725a diff diff %
ydbd size 8 784 784 440 Bytes 8 785 303 608 Bytes +507.0 KiB +0.006%
ydbd stripped size 479 498 440 Bytes 479 419 080 Bytes -77.5 KiB -0.017%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

igormunkin
igormunkin approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@igormunkin igormunkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitstn, thanks for the patch! LGTM.

@vitstn vitstn merged commit 072b721 into ydb-platform:main Aug 27, 2024
12 of 17 checks passed
@vitstn vitstn deleted the pg_lang_sql branch August 27, 2024 05:10
This was referenced Aug 27, 2024
Merged
Merged
rekby pushed a commit to rekby-forks/ydb that referenced this pull request Aug 28, 2024
@vitstn @rekby
Support of functions with lang=sql (ydb-platform#8233)
8dc1961
@niksaveliev niksaveliev mentioned this pull request Aug 29, 2024
Merged
This was referenced Aug 30, 2024
Merged
Merged
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
@vitstn @stanislav-shchetinin
Support of functions with lang=sql (ydb-platform#8233)
9ea8b04
@siarheivesialou siarheivesialou mentioned this pull request Sep 4, 2024
Merged
This was referenced Sep 9, 2024
Merged
Merged
This was referenced Sep 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igormunkin igormunkin igormunkin approved these changes

@nepal nepal Awaiting requested review from nepal

Assignees
No one assigned
Labels
area/pg area/yql YQL query language issues new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitstn @igormunkin