Skip to content

Fix overriding feature flags in CMS #8238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

pixcc
Copy link
Member

@pixcc pixcc commented Aug 25, 2024

Changelog entry

Fixes that an unset feature flags in dynamic config overrides a feature flags in static config for CMS

Changelog category

  • Bugfix

@pixcc pixcc requested a review from CyberROFL August 25, 2024 05:07
Copy link

github-actions bot commented Aug 25, 2024

2024-08-25 05:10:48 UTC Pre-commit check for aa86279 has started.
2024-08-25 05:13:29 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-25 05:18:33 UTC Build successful.

Copy link

github-actions bot commented Aug 25, 2024

2024-08-25 05:11:13 UTC Pre-commit check for aa86279 has started.
2024-08-25 05:13:52 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-25 06:43:23 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9818 9717 0 36 44 21

🟢 2024-08-25 06:44:15 UTC Build successful.
🟢 2024-08-25 06:44:44 UTC ydbd size 5.5 GiB changed* by +384 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: b5dba78 merge: aa86279 diff diff %
ydbd size 5 919 113 664 Bytes 5 919 114 048 Bytes +384 Bytes +0.000%
ydbd stripped size 1 487 402 544 Bytes 1 487 402 544 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 25, 2024

2024-08-26 10:27:53 UTC Pre-commit check for aa86279 has started.
2024-08-26 10:30:36 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-26 11:26:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14227 12840 0 8 1353 26

2024-08-26 11:27:58 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-26 11:36:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
34 (only retried tests) 22 0 1 0 11

2024-08-26 11:36:50 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-26 11:45:11 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 (only retried tests) 8 0 0 0 10

🟢 2024-08-26 11:45:19 UTC Build successful.
🟢 2024-08-26 11:45:59 UTC ydbd size 8.2 GiB changed* by -26.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 92ff6c1 merge: aa86279 diff diff %
ydbd size 8 784 784 440 Bytes 8 784 757 576 Bytes -26.2 KiB -0.000%
ydbd stripped size 479 498 440 Bytes 479 384 264 Bytes -111.5 KiB -0.024%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc merged commit a131ad1 into ydb-platform:main Aug 26, 2024
11 of 13 checks passed
@pixcc pixcc self-assigned this Aug 26, 2024
rekby pushed a commit to rekby-forks/ydb that referenced this pull request Aug 28, 2024
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants