Skip to content

Get rid of copy-pase of TChangeRecordContainer #8352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Aug 27, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Aug 27, 2024

2024-08-27 16:33:25 UTC Pre-commit check for ce96d30 has started.
2024-08-27 16:36:12 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-27 16:44:28 UTC Build successful.

Copy link

github-actions bot commented Aug 27, 2024

2024-08-27 16:33:56 UTC Pre-commit check for ce96d30 has started.
2024-08-27 16:36:42 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-27 17:38:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14572 13151 0 40 1353 28

2024-08-27 17:39:54 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-27 17:49:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69 (only retried tests) 19 0 37 0 13

2024-08-27 17:50:04 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-27 17:57:23 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
55 (only retried tests) 44 0 0 0 11

🟢 2024-08-27 17:57:30 UTC Build successful.
🟢 2024-08-27 17:58:14 UTC ydbd size 8.2 GiB changed* by +16.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 352f804 merge: ce96d30 diff diff %
ydbd size 8 799 879 784 Bytes 8 799 896 312 Bytes +16.1 KiB +0.000%
ydbd stripped size 479 835 592 Bytes 479 836 424 Bytes +832 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 27, 2024

2024-08-27 16:35:19 UTC Pre-commit check for ce96d30 has started.
2024-08-27 16:38:07 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-27 18:12:07 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9975 9901 0 20 26 28

🟢 2024-08-27 18:13:01 UTC Build successful.
🟢 2024-08-27 18:13:31 UTC ydbd size 5.5 GiB changed* by +7.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 352f804 merge: ce96d30 diff diff %
ydbd size 5 928 702 608 Bytes 5 928 710 168 Bytes +7.4 KiB +0.000%
ydbd stripped size 1 489 038 672 Bytes 1 489 038 608 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL self-assigned this Aug 27, 2024
@CyberROFL CyberROFL requested a review from Enjection August 27, 2024 17:14
@CyberROFL CyberROFL marked this pull request as ready for review August 27, 2024 17:14
@CyberROFL CyberROFL merged commit 0b3e86d into ydb-platform:main Aug 28, 2024
12 of 14 checks passed
@CyberROFL CyberROFL deleted the refactoring branch August 28, 2024 10:52
rekby pushed a commit to rekby-forks/ydb that referenced this pull request Aug 28, 2024
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants