Skip to content

Remove DEFINE_SIMPLE_NONLOCAL_EVENT, add TEventSimpleNonLocal #8562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

maximyurchuk
Copy link
Collaborator

@maximyurchuk maximyurchuk commented Aug 31, 2024

Changelog entry

Replace DEFINE_SIMPLE_NONLOCAL_EVENT to TEventSimpleNonLocal (because c++ classes are better than macroses)

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Copy link

github-actions bot commented Aug 31, 2024

2024-08-31 11:47:33 UTC Pre-commit check linux-x86_64-release-asan for 4cf58c6 has started.
2024-08-31 11:50:47 UTC ya make is running...
🔴 2024-08-31 13:59:09 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14047 13978 0 15 35 19

🟢 2024-08-31 14:00:19 UTC Build successful.
🟢 2024-08-31 14:00:49 UTC ydbd size 5.5 GiB changed* by -623.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 658689d merge: 4cf58c6 diff diff %
ydbd size 5 947 779 568 Bytes 5 947 141 504 Bytes -623.1 KiB -0.011%
ydbd stripped size 1 488 525 488 Bytes 1 488 258 352 Bytes -260.9 KiB -0.018%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 31, 2024

2024-08-31 11:49:06 UTC Pre-commit check linux-x86_64-release-clang14 for 4cf58c6 has started.
2024-08-31 11:52:21 UTC ya make is running...
🟢 2024-08-31 12:44:15 UTC Build successful.

Copy link

github-actions bot commented Aug 31, 2024

2024-08-31 11:49:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4cf58c6 has started.
2024-08-31 11:52:28 UTC ya make is running...
🟡 2024-08-31 13:39:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76038 62306 0 12 13703 17

2024-08-31 13:46:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-08-31 13:53:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
35 (only retried tests) 19 0 1 1 14

2024-08-31 13:53:57 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-08-31 14:01:52 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20 (only retried tests) 6 0 1 0 13

🟢 2024-08-31 14:02:01 UTC Build successful.
🟢 2024-08-31 14:02:41 UTC ydbd size 8.3 GiB changed* by -249.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 86bff9d merge: 4cf58c6 diff diff %
ydbd size 8 907 285 088 Bytes 8 907 029 352 Bytes -249.7 KiB -0.003%
ydbd stripped size 481 310 056 Bytes 481 310 056 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 31, 2024

2024-08-31 15:52:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0037f70 has started.
2024-08-31 15:55:33 UTC ya make is running...
🟡 2024-08-31 17:10:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76045 62312 0 14 13699 20

2024-08-31 17:17:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-08-31 17:27:50 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
35 (only retried tests) 20 0 0 1 14

🟢 2024-08-31 17:27:57 UTC Build successful.
🟢 2024-08-31 17:28:31 UTC ydbd size 8.3 GiB changed* by -249.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3675769 merge: 0037f70 diff diff %
ydbd size 8 907 291 816 Bytes 8 907 036 024 Bytes -249.8 KiB -0.003%
ydbd stripped size 481 310 184 Bytes 481 310 120 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 31, 2024

2024-08-31 15:52:22 UTC Pre-commit check linux-x86_64-release-clang14 for 0037f70 has started.
2024-08-31 15:55:43 UTC ya make is running...
🟢 2024-08-31 16:01:59 UTC Build successful.

Copy link

github-actions bot commented Aug 31, 2024

2024-08-31 15:52:23 UTC Pre-commit check linux-x86_64-release-asan for 0037f70 has started.
2024-08-31 15:55:37 UTC ya make is running...
🔴 2024-08-31 17:27:22 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14054 13978 0 13 36 27

🟢 2024-08-31 17:28:31 UTC Build successful.
🟢 2024-08-31 17:29:03 UTC ydbd size 5.5 GiB changed* by -367.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3675769 merge: 0037f70 diff diff %
ydbd size 5 947 522 208 Bytes 5 947 145 920 Bytes -367.5 KiB -0.006%
ydbd stripped size 1 488 292 976 Bytes 1 488 258 160 Bytes -34.0 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk changed the title Remove DEFINE_SIMPLE_NONLOCAL_EVENT Remove DEFINE_SIMPLE_NONLOCAL_EVENT, add TEventSimpleNonLocal Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 08:56:59 UTC Pre-commit check linux-x86_64-release-clang14 for aca1f14 has started.
2024-09-02 09:00:16 UTC ya make is running...
🟢 2024-09-02 09:54:59 UTC Build successful.

Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 08:57:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for aca1f14 has started.
2024-09-02 09:00:38 UTC ya make is running...
🟡 2024-09-02 10:56:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76066 62329 0 12 13705 20

2024-09-02 11:04:30 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-02 11:14:50 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
35 (only retried tests) 21 0 0 0 14

🟢 2024-09-02 11:14:57 UTC Build successful.
🟢 2024-09-02 11:15:33 UTC ydbd size 8.3 GiB changed* by -231.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5cb33a5 merge: aca1f14 diff diff %
ydbd size 8 907 483 728 Bytes 8 907 246 584 Bytes -231.6 KiB -0.003%
ydbd stripped size 481 313 768 Bytes 481 313 768 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 08:57:50 UTC Pre-commit check linux-x86_64-release-asan for aca1f14 has started.
2024-09-02 09:01:07 UTC ya make is running...
🔴 2024-09-02 11:29:18 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14068 13891 0 44 106 27

🟢 2024-09-02 11:30:32 UTC Build successful.
🟢 2024-09-02 11:31:05 UTC ydbd size 5.5 GiB changed* by -363.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5cb33a5 merge: aca1f14 diff diff %
ydbd size 5 947 651 616 Bytes 5 947 279 488 Bytes -363.4 KiB -0.006%
ydbd stripped size 1 488 331 696 Bytes 1 488 292 784 Bytes -38.0 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk marked this pull request as ready for review September 2, 2024 11:18
@maximyurchuk maximyurchuk requested a review from a team as a code owner September 2, 2024 11:18
@maximyurchuk maximyurchuk merged commit e2fecfd into ydb-platform:main Sep 3, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants