Skip to content

Remove legacy tablet APIs #8613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

Remove legacy tablet APIs #8613

merged 1 commit into from
Mar 10, 2025

Conversation

snaury
Copy link
Member

@snaury snaury commented Sep 2, 2024 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

This PR removes legacy tablet APIs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024 •
edited
Loading

⚪ 2024-09-02 14:05:38 UTC Pre-commit check linux-x86_64-release-clang14 for e891645 has started.
⚪ 2024-09-02 14:08:34 UTC ya make is running...
🟢 2024-09-02 14:42:04 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024 •
edited
Loading

⚪ 2024-09-02 14:05:38 UTC Pre-commit check linux-x86_64-release-asan for e891645 has started.
⚪ 2024-09-02 14:08:44 UTC ya make is running...
🔴 2024-09-02 16:12:14 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11475 11396 0 24 30 25

🟢 2024-09-02 16:13:17 UTC Build successful.
🟢 2024-09-02 16:13:49 UTC ydbd size 5.5 GiB changed* by -2.4 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: df05bf8 merge: e891645 diff diff %
ydbd size 5 953 776 272 Bytes 5 951 255 408 Bytes -2.4 MiB -0.042%
ydbd stripped size 1 489 272 336 Bytes 1 488 695 568 Bytes -563.2 KiB -0.039%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024 •
edited
Loading

⚪ 2024-09-02 14:08:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for e891645 has started.
⚪ 2024-09-02 14:11:15 UTC ya make is running...
🟡 2024-09-02 15:39:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40488 35060 0 13 5397 18

⚪ 2024-09-02 15:45:49 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-02 15:54:49 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28 (only retried tests) 15 0 0 0 13

🟢 2024-09-02 15:54:56 UTC Build successful.
🟢 2024-09-02 15:55:29 UTC ydbd size 8.3 GiB changed* by -3.5 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8de51e6 merge: e891645 diff diff %
ydbd size 8 917 637 880 Bytes 8 913 995 424 Bytes -3.5 MiB -0.041%
ydbd stripped size 481 748 872 Bytes 481 578 696 Bytes -166.2 KiB -0.035%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury force-pushed the remove-legacy-tablet-api branch from 21f1297 to 2171fb8 Compare March 7, 2025 09:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

⚪ 2025-03-07 09:39:29 UTC Pre-commit check linux-x86_64-release-asan for d00db4e has started.
⚪ 2025-03-07 09:39:44 UTC Artifacts will be uploaded here
⚪ 2025-03-07 09:42:50 UTC ya make is running...
🟡 2025-03-07 11:20:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13768 13580 0 121 29 38

⚪ 2025-03-07 11:21:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-07 11:42:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
261 (only retried tests) 213 0 8 7 33

⚪ 2025-03-07 11:42:19 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-07 11:57:28 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79 (only retried tests) 40 0 0 6 33

🟢 2025-03-07 11:57:39 UTC Build successful.
🟢 2025-03-07 11:58:10 UTC ydbd size 3.7 GiB changed* by -1.5 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: af2a9a9 merge: d00db4e diff diff %
ydbd size 3 994 259 128 Bytes 3 992 655 584 Bytes -1.5 MiB -0.040%
ydbd stripped size 1 388 747 176 Bytes 1 388 236 648 Bytes -498.6 KiB -0.037%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

⚪ 2025-03-07 09:40:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for d00db4e has started.
⚪ 2025-03-07 09:40:56 UTC Artifacts will be uploaded here
⚪ 2025-03-07 09:44:08 UTC ya make is running...
🟡 2025-03-07 11:12:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28173 25574 0 2 2476 121

⚪ 2025-03-07 11:15:29 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-07 11:27:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
181 (only retried tests) 74 0 0 0 107

🟢 2025-03-07 11:28:08 UTC Build successful.
🟢 2025-03-07 11:28:28 UTC ydbd size 2.1 GiB changed* by -957.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: af2a9a9 merge: d00db4e diff diff %
ydbd size 2 293 420 864 Bytes 2 292 440 176 Bytes -957.7 KiB -0.043%
ydbd stripped size 480 451 296 Bytes 480 284 384 Bytes -163.0 KiB -0.035%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury marked this pull request as ready for review March 7, 2025 12:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

🟢 2025-03-07 12:35:18 UTC The validation of the Pull Request description is successful.

@snaury snaury enabled auto-merge (squash) March 10, 2025 09:39
@gridnevvvit gridnevvvit self-requested a review March 10, 2025 09:40
@snaury snaury merged commit 629823c into ydb-platform:main Mar 10, 2025
14 checks passed
@snaury snaury deleted the remove-legacy-tablet-api branch March 10, 2025 09:40
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 11, 2025
Merged
@naspirato naspirato mentioned this pull request Mar 11, 2025
Closed
@serbel324 serbel324 mentioned this pull request Mar 13, 2025
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
@snaury @adameat
Remove legacy tablet APIs (ydb-platform#8613)
a56f6af
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@snaury @blinkov
Remove legacy tablet APIs (#8613)
3e6ac0f
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
@snaury
Remove legacy tablet APIs (ydb-platform#8613)
9a8aa21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snaury @gridnevvvit