Skip to content

Fix incorrect DC comparison #8747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Sep 4, 2024

Changelog entry

Fix incorrect DC comparison

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Fixed incorrect TString comparison with numeric 0.

adameat
adameat previously approved these changes Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

2024-09-04 14:30:34 UTC Pre-commit check linux-x86_64-release-clang14 for ed2dbde has started.
2024-09-04 14:31:55 UTC Check cancelled

Copy link

github-actions bot commented Sep 4, 2024

2024-09-04 14:33:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for e9ef4e0 has started.
2024-09-04 14:36:15 UTC ya make is running...
🟡 2024-09-04 15:37:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14700 13245 0 71 1363 21

2024-09-04 15:39:15 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-04 15:48:14 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
104 (only retried tests) 89 0 0 0 15

🟢 2024-09-04 15:48:21 UTC Build successful.
🟡 2024-09-04 15:49:02 UTC ydbd size 8.3 GiB changed* by +186.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: dfa0721 merge: e9ef4e0 diff diff %
ydbd size 8 922 565 592 Bytes 8 922 756 032 Bytes +186.0 KiB +0.002%
ydbd stripped size 481 974 600 Bytes 481 976 840 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 4, 2024

2024-09-04 14:35:05 UTC Pre-commit check linux-x86_64-release-asan for e9ef4e0 has started.
2024-09-04 14:37:49 UTC ya make is running...
🔴 2024-09-04 16:14:29 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10085 10013 0 19 28 25

🟢 2024-09-04 16:15:23 UTC Build successful.
🟢 2024-09-04 16:15:51 UTC ydbd size 5.5 GiB changed* by +1.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0ba24ba merge: e9ef4e0 diff diff %
ydbd size 5 957 884 688 Bytes 5 957 886 144 Bytes +1.4 KiB +0.000%
ydbd stripped size 1 490 148 432 Bytes 1 490 148 368 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 4, 2024

2024-09-04 14:35:26 UTC Pre-commit check linux-x86_64-release-clang14 for e9ef4e0 has started.
2024-09-04 14:38:32 UTC ya make is running...
🟢 2024-09-04 14:44:31 UTC Build successful.

@alexvru alexvru merged commit 732bf12 into ydb-platform:main Sep 5, 2024
10 of 12 checks passed
@alexvru alexvru deleted the hive/fix-incorrect-dc-comparison branch September 5, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants