Skip to content

Fix erroneous finish on TDqInputMergeBlockStreamValue #8834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Fix erroneous finish on TDqInputMergeBlockStreamValue #8834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ydb/library/yql/dq/runtime/dq_input_producer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,10 @@ class TDqInputMergeBlockStreamValue : public TComputationValue<TDqInputMergeBloc
return CurrBlockIndex_ >= BlockLen_;
}

bool IsFinished() const {
return IsFinished_;
}

void NextRow() {
Y_DEBUG_ABORT_UNLESS(!IsEmpty());
++CurrBlockIndex_;
Expand Down Expand Up @@ -633,7 +637,7 @@ class TDqInputMergeBlockStreamValue : public TComputationValue<TDqInputMergeBloc
input.NextRow();
InputRows_.pop_back();
if (input.IsEmpty()) {
auto status = input.FetchNext();
auto status = FetchInput(inputIndex);
if (status == NUdf::EFetchStatus::Yield) {
StartInputIndex_ = inputIndex;
return status;
Expand All @@ -645,6 +649,7 @@ class TDqInputMergeBlockStreamValue : public TComputationValue<TDqInputMergeBloc
}

if (!OutputBlockLen_) {
YQL_ENSURE(AllOf(InputData_, [](const TDqInputBatch& input) { return input.IsEmpty() && input.IsFinished(); }));
return NUdf::EFetchStatus::Finish;
}

Expand Down
Loading