Skip to content

Default values for feature flags EnablePQConfigTransactionsAtSchemeshard and EnableTopicServiceTx #8845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented Sep 6, 2024

Changelog entry

Fixed bugs:

  1. Offset blobs were calculated incorrectly when committing an entry in a transaction.
  2. In some cases, it was not possible to complete the transaction after returning the PQ tablet.
  3. Some tests failed with an error if the EnablePQConfigTransactionsAtSchemeshard and EnableTopicSplitMerge flags were enabled.

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner September 6, 2024 09:13
Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 09:14:33 UTC Pre-commit check for 0e27f9f has started.
2024-09-06 09:18:06 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-06 09:58:43 UTC Build successful.
2024-09-06 09:59:00 UTC Tests are running...
🔴 2024-09-06 11:59:30 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11330 11251 0 22 24 33

🟢 2024-09-06 12:00:08 UTC ydbd size 5.5 GiB changed* by -688 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: df7e1b2 merge: 0e27f9f diff diff %
ydbd size 5 934 467 560 Bytes 5 934 466 872 Bytes -688 Bytes -0.000%
ydbd stripped size 1 487 844 352 Bytes 1 487 844 416 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 09:14:46 UTC Pre-commit check for 0e27f9f has started.
2024-09-06 09:17:35 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-06 09:53:42 UTC Build successful.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 09:17:12 UTC Pre-commit check for 0e27f9f has started.
2024-09-06 09:20:13 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-06 10:22:54 UTC Build successful.
2024-09-06 10:23:10 UTC Tests are running...
🔴 2024-09-06 12:14:19 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39886 34614 0 27 5214 31

🟢 2024-09-06 12:15:20 UTC ydbd size 8.2 GiB changed* by -944 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: df7e1b2 merge: 0e27f9f diff diff %
ydbd size 8 760 652 856 Bytes 8 760 651 912 Bytes -944 Bytes -0.000%
ydbd stripped size 478 992 712 Bytes 478 992 712 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 07:24:41 UTC Pre-commit check for 3e4e030 has started.
2024-09-09 07:27:28 UTC Build linux-x86_64-release-clang14 is running...
2024-09-09 07:34:58 UTC Check cancelled

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 07:24:41 UTC Pre-commit check for 3e4e030 has started.
2024-09-09 07:27:28 UTC Build linux-x86_64-relwithdebinfo is running...
2024-09-09 07:34:58 UTC Check cancelled

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 07:25:00 UTC Pre-commit check for 3e4e030 has started.
2024-09-09 07:27:52 UTC Build linux-x86_64-release-asan is running...
2024-09-09 07:35:00 UTC Check cancelled

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 07:37:10 UTC Pre-commit check for 6057de3 has started.
2024-09-09 07:40:04 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-09 08:12:43 UTC Build successful.

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 07:38:25 UTC Pre-commit check for 6057de3 has started.
2024-09-09 07:41:12 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-09 08:35:30 UTC Build successful.
2024-09-09 08:35:48 UTC Tests are running...
🔴 2024-09-09 10:25:21 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39891 34628 0 16 5215 32

🟡 2024-09-09 10:26:22 UTC ydbd size 8.2 GiB changed* by +118.0 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 871adef merge: 6057de3 diff diff %
ydbd size 8 760 911 888 Bytes 8 761 032 688 Bytes +118.0 KiB +0.001%
ydbd stripped size 478 998 600 Bytes 478 998 600 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 07:38:41 UTC Pre-commit check for 6057de3 has started.
2024-09-09 07:41:31 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-09 08:17:41 UTC Build successful.
2024-09-09 08:17:55 UTC Tests are running...
🔴 2024-09-09 10:15:14 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11333 11255 0 22 24 32

🟢 2024-09-09 10:16:05 UTC ydbd size 5.5 GiB changed* by -688 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: fac9434 merge: 6057de3 diff diff %
ydbd size 5 934 639 208 Bytes 5 934 638 520 Bytes -688 Bytes -0.000%
ydbd stripped size 1 487 867 776 Bytes 1 487 867 840 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 13:48:52 UTC Pre-commit check for 2a15552 has started.
2024-09-09 13:51:39 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-09 14:15:36 UTC Build successful.
2024-09-09 14:15:51 UTC Tests are running...
🔴 2024-09-09 16:09:01 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11336 11261 0 19 26 30

🟢 2024-09-09 16:09:36 UTC ydbd size 5.5 GiB changed* by -744 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 42c8024 merge: 2a15552 diff diff %
ydbd size 5 934 678 944 Bytes 5 934 678 200 Bytes -744 Bytes -0.000%
ydbd stripped size 1 487 880 864 Bytes 1 487 880 928 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 13:57:08 UTC Pre-commit check for 2a15552 has started.
2024-09-09 13:59:58 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-09 14:08:17 UTC Build successful.

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 14:05:35 UTC Pre-commit check for 2a15552 has started.
2024-09-09 14:08:52 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-09 14:50:20 UTC Build successful.
2024-09-09 14:50:32 UTC Tests are running...
🔴 2024-09-09 16:47:22 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39895 34635 0 14 5213 33

🟢 2024-09-09 16:48:11 UTC ydbd size 8.2 GiB changed* by -168 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 42c8024 merge: 2a15552 diff diff %
ydbd size 8 761 072 592 Bytes 8 761 072 424 Bytes -168 Bytes -0.000%
ydbd stripped size 479 005 256 Bytes 479 005 064 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 17:12:39 UTC Pre-commit check for 20d8173 has started.
2024-09-09 17:15:26 UTC Build linux-x86_64-release-asan is running...
2024-09-09 17:22:32 UTC Check cancelled

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 17:12:42 UTC Pre-commit check for 20d8173 has started.
2024-09-09 17:15:39 UTC Build linux-x86_64-release-clang14 is running...
2024-09-09 17:22:31 UTC Check cancelled

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 17:12:52 UTC Pre-commit check for 20d8173 has started.
2024-09-09 17:15:49 UTC Build linux-x86_64-relwithdebinfo is running...
2024-09-09 17:22:40 UTC Check cancelled

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 17:26:02 UTC Pre-commit check for 3977812 has started.
2024-09-09 17:28:48 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-09 17:35:41 UTC Build successful.

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 17:26:03 UTC Pre-commit check for 3977812 has started.
2024-09-09 17:28:58 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-09 18:07:26 UTC Build successful.
2024-09-09 18:07:41 UTC Tests are running...
🔴 2024-09-09 19:55:31 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39893 34635 0 14 5212 32

🟢 2024-09-09 19:56:20 UTC ydbd size 8.2 GiB changed* by -152 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 84e30aa merge: 3977812 diff diff %
ydbd size 8 761 168 152 Bytes 8 761 168 000 Bytes -152 Bytes -0.000%
ydbd stripped size 479 010 568 Bytes 479 010 376 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 17:26:38 UTC Pre-commit check for 3977812 has started.
2024-09-09 17:29:28 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-09 17:52:40 UTC Build successful.
2024-09-09 17:52:58 UTC Tests are running...
🔴 2024-09-09 19:46:57 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11337 11266 0 15 24 32

🟢 2024-09-09 19:47:42 UTC ydbd size 5.5 GiB changed* by -736 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 84e30aa merge: 3977812 diff diff %
ydbd size 5 934 793 456 Bytes 5 934 792 720 Bytes -736 Bytes -0.000%
ydbd stripped size 1 487 909 024 Bytes 1 487 909 088 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 08:41:19 UTC Pre-commit check for 0848799 has started.
2024-09-10 08:44:14 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-10 09:09:57 UTC Build successful.
2024-09-10 09:10:14 UTC Tests are running...
🔴 2024-09-10 11:13:11 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11348 11276 0 17 23 32

🟢 2024-09-10 11:13:56 UTC ydbd size 5.5 GiB changed* by +65.3 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 84e30aa merge: 0848799 diff diff %
ydbd size 5 934 793 456 Bytes 5 934 860 312 Bytes +65.3 KiB +0.001%
ydbd stripped size 1 487 909 024 Bytes 1 487 925 280 Bytes +15.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 08:41:46 UTC Pre-commit check for 0848799 has started.
2024-09-10 08:44:35 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-10 09:26:05 UTC Build successful.
2024-09-10 09:26:23 UTC Tests are running...
🔴 2024-09-10 11:12:34 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39904 34645 0 14 5213 32

🟢 2024-09-10 11:13:36 UTC ydbd size 8.2 GiB changed* by +41.8 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 84e30aa merge: 0848799 diff diff %
ydbd size 8 761 168 152 Bytes 8 761 210 976 Bytes +41.8 KiB +0.000%
ydbd stripped size 479 010 568 Bytes 479 014 728 Bytes +4.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 08:41:50 UTC Pre-commit check for 0848799 has started.
2024-09-10 08:45:15 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-10 08:55:50 UTC Build successful.

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 13:32:54 UTC Pre-commit check for d3b6537 has started.
2024-09-10 13:35:28 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-10 13:51:29 UTC Build successful.

@Alek5andr-Kotov Alek5andr-Kotov changed the title WIP: Default values for flags Default values for feature flags EnablePQConfigTransactionsAtSchemeshard and EnableTopicServiceTx Sep 10, 2024
Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 13:34:48 UTC Pre-commit check for d3b6537 has started.
2024-09-10 13:37:25 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-10 14:02:32 UTC Build successful.
2024-09-10 14:02:49 UTC Tests are running...
🔴 2024-09-10 15:54:35 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11213 11151 0 5 26 31

🟢 2024-09-10 15:55:12 UTC ydbd size 5.5 GiB changed* by +65.9 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 6e413ab merge: d3b6537 diff diff %
ydbd size 5 935 236 664 Bytes 5 935 304 096 Bytes +65.9 KiB +0.001%
ydbd stripped size 1 487 982 880 Bytes 1 487 999 008 Bytes +15.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 13:35:44 UTC Pre-commit check for d3b6537 has started.
2024-09-10 13:38:18 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-10 14:20:07 UTC Build successful.
2024-09-10 14:20:23 UTC Tests are running...
🔴 2024-09-10 16:07:15 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39752 34504 0 6 5212 30

🟢 2024-09-10 16:08:51 UTC ydbd size 8.2 GiB changed* by +42.7 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 6e413ab merge: d3b6537 diff diff %
ydbd size 8 761 862 096 Bytes 8 761 905 832 Bytes +42.7 KiB +0.000%
ydbd stripped size 479 033 096 Bytes 479 037 256 Bytes +4.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov merged commit d04d9bb into ydb-platform:stable-24-3 Sep 11, 2024
8 of 12 checks passed
Alek5andr-Kotov added a commit to Alek5andr-Kotov/ydb that referenced this pull request Sep 12, 2024
nshestakov pushed a commit to nshestakov/ydb that referenced this pull request Sep 12, 2024
nshestakov added a commit that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants