Skip to content

YQ-3653 added resource pools classifiers validations #9037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Sep 10, 2024

Changelog entry

Added resource pools classifiers validations

Changelog category

  • Improvement

Additional information

  • Made RESOURCE_POOL property required
  • Added name validation
  • Banned classifiers for system users
  • Fixed classifiers choosing in case of multi user groups

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 18:26:48 UTC Pre-commit check linux-x86_64-release-clang14 for 9418d5d has started.
2024-09-10 18:27:05 UTC Artifacts will be uploaded here
2024-09-10 18:29:50 UTC ya make is running...
2024-09-10 18:31:13 UTC Check cancelled

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 18:27:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9418d5d has started.
2024-09-10 18:27:31 UTC Artifacts will be uploaded here
2024-09-10 18:30:19 UTC ya make is running...
2024-09-10 18:31:13 UTC Check cancelled

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 18:27:44 UTC Pre-commit check linux-x86_64-release-asan for 9418d5d has started.
2024-09-10 18:28:02 UTC Artifacts will be uploaded here
2024-09-10 18:30:45 UTC ya make is running...
2024-09-10 18:31:12 UTC Check cancelled

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 18:32:53 UTC Pre-commit check linux-x86_64-release-clang14 for 47e79c0 has started.
2024-09-10 18:33:04 UTC Artifacts will be uploaded here
2024-09-10 18:35:45 UTC ya make is running...
🟢 2024-09-10 18:41:26 UTC Build successful.

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 18:33:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 47e79c0 has started.
2024-09-10 18:33:55 UTC Artifacts will be uploaded here
2024-09-10 18:37:08 UTC ya make is running...
🟡 2024-09-10 19:42:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39727 33955 0 185 5487 100

2024-09-10 19:46:37 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-10 19:56:39 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
349 (only retried tests) 258 0 0 8 83

🟢 2024-09-10 19:56:47 UTC Build successful.
🟡 2024-09-10 19:57:29 UTC ydbd size 8.4 GiB changed* by +191.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9e26730 merge: 47e79c0 diff diff %
ydbd size 9 026 440 000 Bytes 9 026 635 752 Bytes +191.2 KiB +0.002%
ydbd stripped size 487 750 952 Bytes 487 756 520 Bytes +5.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 18:33:07 UTC Pre-commit check linux-x86_64-release-asan for 47e79c0 has started.
2024-09-10 18:34:54 UTC Artifacts will be uploaded here
2024-09-10 18:37:38 UTC ya make is running...
🔴 2024-09-10 20:18:54 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10472 10133 0 43 266 30

🟢 2024-09-10 20:19:48 UTC Build successful.
🟢 2024-09-10 20:20:38 UTC ydbd size 5.6 GiB changed* by +94.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9e26730 merge: 47e79c0 diff diff %
ydbd size 6 038 753 872 Bytes 6 038 851 008 Bytes +94.9 KiB +0.002%
ydbd stripped size 1 511 299 888 Bytes 1 511 320 688 Bytes +20.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit 5a4c7c7 into ydb-platform:main Sep 11, 2024
10 of 12 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-3653-fix-resource-pool-classifiers branch September 11, 2024 09:54
@shnikd shnikd mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants