Skip to content

YQL: Add seed optional argument to Digest::CityHash() call #9409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

mxkovalev
Copy link
Member

No description provided.

@mxkovalev mxkovalev requested a review from rvu1024 September 17, 2024 20:43
@mxkovalev mxkovalev self-assigned this Sep 17, 2024
@mxkovalev mxkovalev requested a review from a team as a code owner September 17, 2024 20:43
Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 20:45:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6f2ad20 has started.
2024-09-17 20:45:25 UTC Artifacts will be uploaded here
2024-09-17 20:47:40 UTC Check cancelled

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 20:51:24 UTC Pre-commit check linux-x86_64-release-clang14 for 7613380 has started.
2024-09-17 20:51:33 UTC Artifacts will be uploaded here
2024-09-17 20:54:01 UTC ya make is running...
🟢 2024-09-17 20:56:23 UTC Build successful.

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 20:51:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7613380 has started.
2024-09-17 20:51:51 UTC Artifacts will be uploaded here
2024-09-17 20:54:18 UTC ya make is running...
🟡 2024-09-17 21:35:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59055 45638 0 1 13342 74

2024-09-17 21:40:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-17 21:43:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73 (only retried tests) 1 0 1 0 71

2024-09-17 21:43:57 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-17 21:47:22 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72 (only retried tests) 0 0 1 0 71

🟢 2024-09-17 21:47:29 UTC Build successful.
🟢 2024-09-17 21:47:51 UTC ydbd size 8.4 GiB changed* by +31.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7873f89 merge: 7613380 diff diff %
ydbd size 9 034 329 384 Bytes 9 034 361 584 Bytes +31.4 KiB +0.000%
ydbd stripped size 488 824 072 Bytes 488 824 488 Bytes +416 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 20:51:53 UTC Pre-commit check linux-x86_64-release-asan for 7613380 has started.
2024-09-17 20:52:04 UTC Artifacts will be uploaded here
2024-09-17 20:54:48 UTC ya make is running...
🔴 2024-09-17 21:52:42 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2986 2737 0 26 115 108

🟢 2024-09-17 21:53:04 UTC Build successful.
🟢 2024-09-17 21:53:30 UTC ydbd size 5.6 GiB changed* by +27.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7873f89 merge: 7613380 diff diff %
ydbd size 6 048 555 168 Bytes 6 048 582 856 Bytes +27.0 KiB +0.000%
ydbd stripped size 1 513 394 768 Bytes 1 513 403 760 Bytes +8.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 09:18:45 UTC Pre-commit check linux-x86_64-release-asan for 00c1fba has started.
2024-09-18 09:18:56 UTC Artifacts will be uploaded here
2024-09-18 09:21:30 UTC ya make is running...
🔴 2024-09-18 10:18:47 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2986 2769 0 31 81 105

🟢 2024-09-18 10:19:07 UTC Build successful.
🟡 2024-09-18 10:19:34 UTC ydbd size 5.6 GiB changed* by +140.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: dcbd0e0 merge: 00c1fba diff diff %
ydbd size 6 048 569 720 Bytes 6 048 713 448 Bytes +140.4 KiB +0.002%
ydbd stripped size 1 513 402 000 Bytes 1 513 432 112 Bytes +29.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 09:18:47 UTC Pre-commit check linux-x86_64-release-clang14 for 00c1fba has started.
2024-09-18 09:18:57 UTC Artifacts will be uploaded here
2024-09-18 09:21:24 UTC ya make is running...
🟢 2024-09-18 09:23:49 UTC Build successful.

Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 09:18:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for 00c1fba has started.
2024-09-18 09:19:05 UTC Artifacts will be uploaded here
2024-09-18 09:21:35 UTC ya make is running...
🟢 2024-09-18 10:01:17 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59055 45636 0 0 13343 76

🟢 2024-09-18 10:07:12 UTC Build successful.
🟡 2024-09-18 10:07:32 UTC ydbd size 8.4 GiB changed* by +156.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: dcbd0e0 merge: 00c1fba diff diff %
ydbd size 9 034 337 832 Bytes 9 034 497 832 Bytes +156.2 KiB +0.002%
ydbd stripped size 488 828 424 Bytes 488 838 088 Bytes +9.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@mxkovalev mxkovalev changed the title YQL: Add CityHash64WithSeed() to Digest UDF YQL: Add seed optional argument to Digest::CityHash() call Sep 18, 2024
rvu1024
rvu1024 previously approved these changes Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 11:08:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for dd399c5 has started.
2024-09-18 11:08:18 UTC Artifacts will be uploaded here
2024-09-18 11:10:52 UTC ya make is running...
🟢 2024-09-18 11:53:02 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59055 45634 0 0 13344 77

🟢 2024-09-18 11:58:22 UTC Build successful.
🟢 2024-09-18 11:58:48 UTC ydbd size 8.4 GiB changed* by +4.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 853d462 merge: dd399c5 diff diff %
ydbd size 9 037 429 088 Bytes 9 037 433 688 Bytes +4.5 KiB +0.000%
ydbd stripped size 489 007 688 Bytes 489 007 688 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 11:08:26 UTC Pre-commit check linux-x86_64-release-clang14 for dd399c5 has started.
2024-09-18 11:08:29 UTC Artifacts will be uploaded here
2024-09-18 11:10:54 UTC ya make is running...
🟢 2024-09-18 11:16:24 UTC Build successful.

Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 11:09:12 UTC Pre-commit check linux-x86_64-release-asan for dd399c5 has started.
2024-09-18 11:09:15 UTC Artifacts will be uploaded here
2024-09-18 11:11:48 UTC ya make is running...
🔴 2024-09-18 12:07:47 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2978 2786 0 22 76 94

🟢 2024-09-18 12:08:06 UTC Build successful.
🟢 2024-09-18 12:08:31 UTC ydbd size 5.6 GiB changed* by +2.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 853d462 merge: dd399c5 diff diff %
ydbd size 6 053 415 848 Bytes 6 053 418 216 Bytes +2.3 KiB +0.000%
ydbd stripped size 1 514 440 304 Bytes 1 514 440 240 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@blinkov
Copy link
Member

blinkov commented Sep 19, 2024

lgtm

@mxkovalev mxkovalev merged commit 8a5b980 into ydb-platform:main Sep 19, 2024
11 of 13 checks passed
@shnikd shnikd mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants