Skip to content

Rename HasNotRight -> HasNoRight in tests #9550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Rename HasNotRight -> HasNoRight in tests #9550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ydb/core/tx/schemeshard/ut_base/ut_base.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ Y_UNIT_TEST_SUITE(TSchemeShardTest) {
TestDescribeResult(DescribePath(runtime, "/MyRoot/DirA"),
{NLs::PathVersionEqual(6),
NLs::HasEffectiveRight("+U:user0@builtin"),
NLs::HasNotEffectiveRight("+U:user1@builtin:-")});
NLs::HasNoEffectiveRight("+U:user1@builtin:-")});

{
TestMkDir(runtime, ++txId, "/MyRoot/DirA", "DirB");
Expand All @@ -616,7 +616,7 @@ Y_UNIT_TEST_SUITE(TSchemeShardTest) {
TestDescribeResult(DescribePath(runtime, "/MyRoot/DirA/DirB"),
{NLs::PathVersionEqual(5),
NLs::HasEffectiveRight("+U:user0@builtin"),
NLs::HasNotEffectiveRight("+U:user1@builtin:-")});
NLs::HasNoEffectiveRight("+U:user1@builtin:-")});

}

Expand Down
4 changes: 2 additions & 2 deletions ydb/core/tx/schemeshard/ut_helpers/ls_checks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1254,7 +1254,7 @@ TCheckFunc HasRight(const TString& right) {
};
}

TCheckFunc HasNotRight(const TString& right) {
TCheckFunc HasNoRight(const TString& right) {
return [=] (const NKikimrScheme::TEvDescribeSchemeResult& record) {
CheckRight(record, right, false, true);
};
Expand All @@ -1270,7 +1270,7 @@ TCheckFunc HasEffectiveRight(const TString& right) {
};
}

TCheckFunc HasNotEffectiveRight(const TString& right) {
TCheckFunc HasNoEffectiveRight(const TString& right) {
return [=] (const NKikimrScheme::TEvDescribeSchemeResult& record) {
CheckEffectiveRight(record, right, false);
};
Expand Down
4 changes: 2 additions & 2 deletions ydb/core/tx/schemeshard/ut_helpers/ls_checks.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,9 @@ namespace NLs {

TCheckFunc HasOwner(const TString& owner);
TCheckFunc HasRight(const TString& right);
TCheckFunc HasNotRight(const TString& right);
TCheckFunc HasNoRight(const TString& right);
TCheckFunc HasEffectiveRight(const TString& right);
TCheckFunc HasNotEffectiveRight(const TString& right);
TCheckFunc HasNoEffectiveRight(const TString& right);

TCheckFunc KesusConfigIs(ui64 self_check_period_millis, ui64 session_grace_period_millis);
TCheckFunc DatabaseQuotas(ui64 dataStreamShards);
Expand Down
6 changes: 3 additions & 3 deletions ydb/core/tx/schemeshard/ut_restore/ut_restore.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3991,9 +3991,9 @@ Y_UNIT_TEST_SUITE(TImportTests) {
TestDescribeResult(DescribePath(runtime, "/MyRoot/Table"), {
NLs::PathExist,
NLs::HasOwner(userSID),
NLs::HasNotRight("+R:alice"),
NLs::HasNotRight("+W:alice"),
NLs::HasNotRight("+R:bob")
NLs::HasNoRight("+R:alice"),
NLs::HasNoRight("+W:alice"),
NLs::HasNoRight("+R:bob")
});
}
}
Expand Down