Skip to content

fix segfault #9551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

adameat
Copy link
Member

@adameat adameat commented Sep 20, 2024

Changelog entry

fix segfault, closes #9549

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

@adameat adameat requested a review from a team as a code owner September 20, 2024 09:11
@adameat adameat enabled auto-merge (squash) September 20, 2024 09:12
Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 09:15:38 UTC Pre-commit check linux-x86_64-release-clang14 for d65af5e has started.
2024-09-20 09:15:47 UTC Artifacts will be uploaded here
2024-09-20 09:18:33 UTC ya make is running...
🟢 2024-09-20 09:24:52 UTC Build successful.

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 09:16:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for d65af5e has started.
2024-09-20 09:16:50 UTC Artifacts will be uploaded here
2024-09-20 09:19:47 UTC ya make is running...
🟡 2024-09-20 10:22:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14717 13063 0 9 1609 36

2024-09-20 10:23:37 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-20 10:35:08 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
289 (only retried tests) 187 0 0 8 94

🟢 2024-09-20 10:35:16 UTC Build successful.
🟢 2024-09-20 10:36:12 UTC ydbd size 8.4 GiB changed* by +64 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: c41289f merge: d65af5e diff diff %
ydbd size 9 041 978 360 Bytes 9 041 978 424 Bytes +64 Bytes +0.000%
ydbd stripped size 489 279 624 Bytes 489 279 624 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 09:16:34 UTC Pre-commit check linux-x86_64-release-asan for d65af5e has started.
2024-09-20 09:16:43 UTC Artifacts will be uploaded here
2024-09-20 09:19:32 UTC ya make is running...
🔴 2024-09-20 11:30:57 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10284 9772 0 88 372 52

🟢 2024-09-20 11:31:51 UTC Build successful.
🟢 2024-09-20 11:32:29 UTC ydbd size 5.6 GiB changed* by -80 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: c41289f merge: d65af5e diff diff %
ydbd size 6 060 511 912 Bytes 6 060 511 832 Bytes -80 Bytes -0.000%
ydbd stripped size 1 516 113 392 Bytes 1 516 113 328 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat merged commit 1d31583 into ydb-platform:main Sep 20, 2024
11 of 13 checks passed
adameat added a commit to adameat/ydb that referenced this pull request Oct 1, 2024
adameat added a commit to adameat/ydb that referenced this pull request Oct 4, 2024
@adameat adameat deleted the fix-segfault-on-experimentalcs branch November 14, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

segfault in TViewerPipeClient::NeedToRedirect
2 participants