Skip to content

work #9624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 1, 2024
Merged

work #9624

merged 9 commits into from
Oct 1, 2024

Conversation

andrewstalin
Copy link
Contributor

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

⚪ 2024-09-23 10:29:38 UTC Pre-commit check linux-x86_64-release-asan for 5802ef2 has started.
⚪ 2024-09-23 10:29:49 UTC Artifacts will be uploaded here
⚪ 2024-09-23 10:32:41 UTC ya make is running...
🔴 2024-09-23 12:13:26 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10410 10225 0 40 40 105

🟢 2024-09-23 12:14:22 UTC Build successful.
🟡 2024-09-23 12:14:55 UTC ydbd size 5.6 GiB changed* by +435.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ae1b51a merge: 5802ef2 diff diff %
ydbd size 6 064 262 576 Bytes 6 064 708 864 Bytes +435.8 KiB +0.007%
ydbd stripped size 1 516 876 752 Bytes 1 516 971 728 Bytes +92.8 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

⚪ 2024-09-23 10:32:21 UTC Pre-commit check linux-x86_64-release-clang14 for 5802ef2 has started.
⚪ 2024-09-23 10:32:31 UTC Artifacts will be uploaded here
⚪ 2024-09-23 10:35:25 UTC ya make is running...
🟢 2024-09-23 10:53:21 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

⚪ 2024-09-23 10:32:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5802ef2 has started.
⚪ 2024-09-23 10:32:38 UTC Artifacts will be uploaded here
⚪ 2024-09-23 10:35:34 UTC ya make is running...
🟡 2024-09-23 11:40:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14873 13226 0 7 1604 36

⚪ 2024-09-23 11:41:24 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-23 11:53:01 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
281 (only retried tests) 181 0 0 8 92

🟢 2024-09-23 11:53:10 UTC Build successful.
🟡 2024-09-23 11:53:49 UTC ydbd size 8.4 GiB changed* by +702.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ae1b51a merge: 5802ef2 diff diff %
ydbd size 9 046 511 176 Bytes 9 047 229 984 Bytes +702.0 KiB +0.008%
ydbd stripped size 489 505 576 Bytes 489 533 032 Bytes +26.8 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 07:44:39 UTC Pre-commit check linux-x86_64-release-clang14 for 5bd3dab has started.
⚪ 2024-09-24 07:44:49 UTC Artifacts will be uploaded here
⚪ 2024-09-24 07:47:37 UTC ya make is running...
🟢 2024-09-24 07:54:29 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 07:45:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5bd3dab has started.
⚪ 2024-09-24 07:45:16 UTC Artifacts will be uploaded here
⚪ 2024-09-24 07:48:15 UTC ya make is running...
🟡 2024-09-24 08:55:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14897 13418 0 3 1377 99

⚪ 2024-09-24 08:56:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-24 09:07:49 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
105 (only retried tests) 15 0 0 0 90

🟢 2024-09-24 09:07:55 UTC Build successful.
🟡 2024-09-24 09:08:43 UTC ydbd size 8.4 GiB changed* by +574.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d2b896d merge: 5bd3dab diff diff %
ydbd size 9 071 190 256 Bytes 9 071 778 632 Bytes +574.6 KiB +0.006%
ydbd stripped size 490 550 600 Bytes 490 567 368 Bytes +16.4 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 07:45:08 UTC Pre-commit check linux-x86_64-release-asan for 5bd3dab has started.
⚪ 2024-09-24 07:45:19 UTC Artifacts will be uploaded here
⚪ 2024-09-24 07:48:12 UTC ya make is running...
🔴 2024-09-24 09:40:12 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10443 10234 0 46 40 123

🟢 2024-09-24 09:41:06 UTC Build successful.
🟡 2024-09-24 09:41:40 UTC ydbd size 5.7 GiB changed* by +480.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1002b94 merge: 5bd3dab diff diff %
ydbd size 6 079 048 480 Bytes 6 079 540 952 Bytes +480.9 KiB +0.008%
ydbd stripped size 1 519 895 600 Bytes 1 520 001 680 Bytes +103.6 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

⚪ 2024-09-26 04:57:14 UTC Pre-commit check linux-x86_64-release-clang14 for 755e5b8 has started.
⚪ 2024-09-26 04:57:23 UTC Artifacts will be uploaded here
⚪ 2024-09-26 05:00:11 UTC ya make is running...
🔴 2024-09-26 05:03:25 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

⚪ 2024-09-26 04:57:20 UTC Pre-commit check linux-x86_64-release-asan for 755e5b8 has started.
⚪ 2024-09-26 04:57:29 UTC Artifacts will be uploaded here
⚪ 2024-09-26 05:00:17 UTC ya make is running...
🔴 2024-09-26 05:03:24 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

⚪ 2024-09-26 04:59:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 755e5b8 has started.
⚪ 2024-09-26 05:00:04 UTC Artifacts will be uploaded here
⚪ 2024-09-26 05:02:58 UTC ya make is running...
🔴 2024-09-26 05:06:41 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

⚪ 2024-09-26 09:34:41 UTC Pre-commit check linux-x86_64-release-asan for 56203e3 has started.
⚪ 2024-09-26 09:34:45 UTC Artifacts will be uploaded here
⚪ 2024-09-26 09:37:32 UTC ya make is running...
🟡 2024-09-26 11:44:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10457 10085 0 48 270 54

🟢 2024-09-26 11:45:11 UTC Build successful.
🟡 2024-09-26 11:45:47 UTC ydbd size 5.7 GiB changed* by +1.3 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6bec40a merge: 56203e3 diff diff %
ydbd size 6 082 867 336 Bytes 6 084 212 056 Bytes +1.3 MiB +0.022%
ydbd stripped size 1 520 480 336 Bytes 1 520 783 472 Bytes +296.0 KiB +0.020%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

⚪ 2024-09-26 09:34:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for 56203e3 has started.
⚪ 2024-09-26 09:35:03 UTC Artifacts will be uploaded here
⚪ 2024-09-26 09:37:52 UTC ya make is running...
🟡 2024-09-26 11:10:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14925 13218 0 16 1637 54

⚪ 2024-09-26 11:11:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-26 11:23:22 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
333 (only retried tests) 236 0 0 7 90

🟢 2024-09-26 11:23:31 UTC Build successful.
🔴 2024-09-26 11:24:11 UTC ydbd size 8.5 GiB changed* by +2.1 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 6bec40a merge: 56203e3 diff diff %
ydbd size 9 077 792 816 Bytes 9 079 955 144 Bytes +2.1 MiB +0.024%
ydbd stripped size 490 775 816 Bytes 490 852 232 Bytes +74.6 KiB +0.016%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

⚪ 2024-09-26 09:34:55 UTC Pre-commit check linux-x86_64-release-clang14 for 56203e3 has started.
⚪ 2024-09-26 09:34:58 UTC Artifacts will be uploaded here
⚪ 2024-09-26 09:37:45 UTC ya make is running...
🟢 2024-09-26 10:15:52 UTC Build successful.

azevaykin
azevaykin requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@azevaykin azevaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic is becoming more complicated.
How about a unit test?

@andrewstalin
Copy link
Contributor Author

Logic is becoming more complicated. How about a unit test?

What for? The functionality is used as part of the administrative UI once a year. There's not have anything to test there, just 200 lines of code with no state.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

⚪ 2024-09-30 11:24:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0dadd64 has started.
⚪ 2024-09-30 11:24:47 UTC Artifacts will be uploaded here
🔴 2024-09-30 11:26:42 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

⚪ 2024-09-30 11:24:48 UTC Pre-commit check linux-x86_64-release-asan for 0dadd64 has started.
⚪ 2024-09-30 11:24:58 UTC Artifacts will be uploaded here
🔴 2024-09-30 11:26:50 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

⚪ 2024-09-30 11:43:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 98f688e has started.
⚪ 2024-09-30 11:43:37 UTC Artifacts will be uploaded here
⚪ 2024-09-30 11:46:34 UTC ya make is running...
🟡 2024-09-30 12:31:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14960 13480 0 4 1377 99

⚪ 2024-09-30 12:33:13 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-30 12:45:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 9 0 1 0 91

⚪ 2024-09-30 12:45:26 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-09-30 12:56:38 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
92 (only retried tests) 1 0 0 0 91

🟢 2024-09-30 12:56:45 UTC Build successful.
🟡 2024-09-30 12:57:40 UTC ydbd size 2.8 GiB changed* by +157.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: fbe6aca merge: 98f688e diff diff %
ydbd size 3 001 429 136 Bytes 3 001 590 344 Bytes +157.4 KiB +0.005%
ydbd stripped size 477 332 328 Bytes 477 352 040 Bytes +19.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

⚪ 2024-09-30 11:44:58 UTC Pre-commit check linux-x86_64-release-asan for 98f688e has started.
⚪ 2024-09-30 11:45:08 UTC Artifacts will be uploaded here
⚪ 2024-09-30 11:48:08 UTC ya make is running...
🟡 2024-09-30 13:44:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10512 10278 0 56 55 123

🟢 2024-09-30 13:44:55 UTC Build successful.
🟡 2024-09-30 13:45:33 UTC ydbd size 5.7 GiB changed* by +333.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: fbe6aca merge: 98f688e diff diff %
ydbd size 6 085 233 216 Bytes 6 085 574 608 Bytes +333.4 KiB +0.006%
ydbd stripped size 1 520 350 960 Bytes 1 520 419 184 Bytes +66.6 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

azevaykin
azevaykin reviewed Sep 30, 2024
View reviewed changes
ydb/core/statistics/service/ut/ut_http_request.cpp Outdated
auto msg = static_cast<NMon::TEvHttpInfoRes*>(res->Get());

Cerr << "Answer: '" << msg->Answer << "'" << Endl;
UNIT_ASSERT(msg->Answer.find("Analyze sent. OperationId:") != TString::npos);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNIT_ASSERT_STRING_CONTAINS

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024 •
edited
Loading

⚪ 2024-10-01 07:43:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for a8645b5 has started.
⚪ 2024-10-01 07:43:38 UTC Artifacts will be uploaded here
⚪ 2024-10-01 07:46:38 UTC ya make is running...
🟡 2024-10-01 08:34:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14968 13486 0 2 1377 103

⚪ 2024-10-01 08:35:56 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-01 08:47:07 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
97 (only retried tests) 4 0 0 0 93

🟢 2024-10-01 08:47:13 UTC Build successful.
🟡 2024-10-01 08:47:36 UTC ydbd size 2.8 GiB changed* by +163.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b5341bd merge: a8645b5 diff diff %
ydbd size 3 001 604 736 Bytes 3 001 772 504 Bytes +163.8 KiB +0.006%
ydbd stripped size 477 347 912 Bytes 477 372 360 Bytes +23.9 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024 •
edited
Loading

⚪ 2024-10-01 07:43:43 UTC Pre-commit check linux-x86_64-release-asan for a8645b5 has started.
⚪ 2024-10-01 07:43:53 UTC Artifacts will be uploaded here
⚪ 2024-10-01 07:46:42 UTC ya make is running...
🟡 2024-10-01 09:35:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10510 10272 0 51 60 127

🟢 2024-10-01 09:36:18 UTC Build successful.
🟡 2024-10-01 09:36:55 UTC ydbd size 5.7 GiB changed* by +334.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b5341bd merge: a8645b5 diff diff %
ydbd size 6 085 536 320 Bytes 6 085 878 992 Bytes +334.6 KiB +0.006%
ydbd stripped size 1 520 433 392 Bytes 1 520 499 440 Bytes +64.5 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@andrewstalin andrewstalin merged commit e0fcd02 into ydb-platform:main Oct 1, 2024
10 checks passed
@GrigoriyPA GrigoriyPA mentioned this pull request Oct 8, 2024
Merged
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Oct 18, 2024
@andrewstalin @azevaykin
work (ydb-platform#9624)
40a9e04
This was referenced Oct 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azevaykin azevaykin azevaykin approved these changes

@alexd65536 alexd65536 Awaiting requested review from alexd65536

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewstalin @azevaykin