Skip to content

Fixed computation of ByteSize for CBO for OLAP tables #9626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

pavelvelikhov
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Bugfix

Additional information

...

Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 11:05:58 UTC Pre-commit check linux-x86_64-release-asan for 6a52da3 has started.
2024-09-23 11:06:08 UTC Artifacts will be uploaded here
2024-09-23 11:08:34 UTC ya make is running...
🟢 2024-09-23 11:15:33 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
249 249 0 0 0 0

🟢 2024-09-23 11:15:40 UTC Build successful.

Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 11:06:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6a52da3 has started.
2024-09-23 11:06:49 UTC Artifacts will be uploaded here
2024-09-23 11:09:19 UTC ya make is running...
🟢 2024-09-23 11:12:59 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
249 249 0 0 0 0

🟢 2024-09-23 11:13:06 UTC Build successful.

Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 11:07:08 UTC Pre-commit check linux-x86_64-release-clang14 for 6a52da3 has started.
2024-09-23 11:07:18 UTC Artifacts will be uploaded here
2024-09-23 11:09:37 UTC ya make is running...
🟢 2024-09-23 11:12:08 UTC Build successful.

@pavelvelikhov pavelvelikhov requested review from a team as code owners September 23, 2024 14:29
@pavelvelikhov pavelvelikhov changed the title Unit test for CBO regression Fixed computation of ByteSize for CBO for OLAP tables Sep 23, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Sep 23, 2024
Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 14:35:26 UTC Pre-commit check linux-x86_64-release-asan for e0c86fe has started.
2024-09-23 14:35:30 UTC Artifacts will be uploaded here
2024-09-23 14:38:23 UTC ya make is running...
🔴 2024-09-23 16:21:08 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11133 10773 0 34 271 55

🟢 2024-09-23 16:22:06 UTC Build successful.
🟢 2024-09-23 16:22:39 UTC ydbd size 5.7 GiB changed* by +6.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9918d3c merge: e0c86fe diff diff %
ydbd size 6 078 878 936 Bytes 6 078 885 480 Bytes +6.4 KiB +0.000%
ydbd stripped size 1 519 879 184 Bytes 1 519 880 464 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 14:42:40 UTC Pre-commit check linux-x86_64-release-clang14 for e0c86fe has started.
2024-09-23 14:43:08 UTC Artifacts will be uploaded here
2024-09-23 14:46:01 UTC ya make is running...
🟢 2024-09-23 14:52:31 UTC Build successful.

Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 14:49:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for e0c86fe has started.
2024-09-23 14:49:29 UTC Artifacts will be uploaded here
2024-09-23 14:52:30 UTC ya make is running...
🟡 2024-09-23 16:08:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73581 59654 0 6 13824 97

2024-09-23 16:15:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-23 16:27:13 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 17 0 0 0 89

🟢 2024-09-23 16:27:20 UTC Build successful.
🟢 2024-09-23 16:28:00 UTC ydbd size 8.4 GiB changed* by +2.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9918d3c merge: e0c86fe diff diff %
ydbd size 9 070 502 240 Bytes 9 070 504 336 Bytes +2.0 KiB +0.000%
ydbd stripped size 490 539 144 Bytes 490 539 400 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants