Skip to content

Mount additional volumes to 'postgres' container when 'targetContains` is an empty list #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2021
Merged

Mount additional volumes to 'postgres' container when 'targetContains` is an empty list #1475

merged 2 commits into from
May 27, 2021

Conversation

cucxabong
Copy link
Contributor

Fix #1459

FxKu
FxKu reviewed May 3, 2021
View reviewed changes
@FxKu FxKu added this to the 1.6.3 milestone May 3, 2021
@FxKu
Copy link
Member

FxKu commented May 17, 2021

@cucxabong could you add test cases here for targetContainers being nil and empty ([]string{}). I tried with adding the cases to additionalVolumeMount variable and raised numMounts by it's length. But maybe you got a better idea.

@FxKu
Copy link
Member

FxKu commented May 27, 2021

👍

2 similar comments
@RafiaSabih
Copy link
Contributor

👍

@sdudoladov
Copy link
Member

👍

@sdudoladov sdudoladov merged commit af5378e into zalando:master May 27, 2021
@FxKu FxKu mentioned this pull request May 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FxKu FxKu FxKu left review comments

@CyberDem0n CyberDem0n Awaiting requested review from CyberDem0n

@erthalion erthalion Awaiting requested review from erthalion

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@RafiaSabih RafiaSabih Awaiting requested review from RafiaSabih

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.3
Development

Successfully merging this pull request may close these issues.

No additionalVolumes mounted when targetContainers is an empty list
4 participants
@cucxabong @FxKu @RafiaSabih @sdudoladov