Introduce "ignored_service_annotations" parameter #1482
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdressler
requested review from
CyberDem0n,
erthalion,
FxKu,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
|
Thanks for the PR! (coming here from https://twitter.com/theDressler/status/1389482796872347648) |
|
We have the same issue here what you said some like random cut connections and sync service due to custom service annotations and thanks for the PR. It's looking good and clean, we will try and do feedback if it is necessary, and help this PR to merge. |
|
Hi @sdressler , thanks for mention this. |
|
Finally, we merged this feature with #1823. Thanks again @sdressler for your first approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #1478 by introducing a parameter to ignore specific service annotations.
Rationale: on, e.g., Rancher, additional annotations are added to the LB services. They seem to cause a connection drop on service syncs. These annotations are added again after removal by the operator, enforcing recurring but unnecessary syncs. A solution to prevent this is to ignore these if they are known.