Skip to content

minor fixes to password rotation #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 25, 2022
Merged

minor fixes to password rotation #1796

merged 7 commits into from
Feb 25, 2022

Conversation

FxKu
Copy link
Member

@FxKu FxKu commented Feb 23, 2022

  1. When the next rotation date is set the period should be added to the current time, not to the time in the secret. In case the timestamp in the secret would be very old, it would need a few unnecessary rotations until we reach the current time.
  2. The timestamp in the secret should also store the timestamp. We can just use Go's time.RFC3339 constant and do not worry about the format. As location we hardcode to UTC.
  3. The complete manifest was giving wrong examples for password rotation options.

@FxKu FxKu added this to the 1.8 milestone Feb 23, 2022
@sdudoladov
Copy link
Member

👍

@jopadi
Copy link
Member

jopadi commented Feb 25, 2022

👍

1 similar comment
@FxKu
Copy link
Member Author

FxKu commented Feb 25, 2022

👍

@FxKu FxKu merged commit 8b404fd into master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@CyberDem0n CyberDem0n Awaiting requested review from CyberDem0n

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@FxKu @sdudoladov @jopadi