do not call EBS api when there are no pvs #1851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
sdudoladov,
Jan-M,
CyberDem0n and
jopadi
as code owners
FxKu
commented
Apr 14, 2022
| return nil | ||
| } | ||
| c.logger.Infof("starting EBS gp2 to gp3 migration") | ||
|
|
There was a problem hiding this comment.
c.OpConfig.EnableEBSGp3Migration is already checked before calling executeEBSMigration. The log line is quite confusing because the function is executed every sync and at this point it's not decided yet, that a migration is actually happening.
FxKu
commented
Apr 14, 2022
| @@ -149,7 +148,11 @@ func (c *Cluster) populateVolumeMetaData() error { | |||
| if err != nil { | |||
| return fmt.Errorf("could not list persistent volumes: %v", err) | |||
| } | |||
| c.logger.Debugf("found %d volumes, size of known volumes %d", len(pvs), len(c.EBSVolumes)) | |||
| if len(pvs) == 0 { | |||
| c.EBSVolumes = make(map[string]volumes.VolumeProperties) | |||
There was a problem hiding this comment.
reset c.EBSVolumes when there are no persistent volume claims
FxKu
commented
Apr 19, 2022
| @@ -167,7 +170,7 @@ func (c *Cluster) populateVolumeMetaData() error { | |||
| return err | |||
| } | |||
|
|
|||
| if len(currentVolumes) != len(c.EBSVolumes) { | |||
| if len(currentVolumes) != len(c.EBSVolumes) && len(c.EBSVolumes) > 0 { | |||
There was a problem hiding this comment.
On first run c.EBSVolumes will be empty at this point. We already logged the size of known volumes above. Therefore, we should print this debug message only on subsequent sync runs and only if there is a difference.
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only minor adjustments to improve syncing volumes when resize mode is
ebs.