Skip to content

allow in place pw rotation of system users #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 18, 2022
Merged

Conversation

FxKu
Copy link
Member

@FxKu FxKu commented Jul 6, 2022

First approach to support password rotation for system users except postgres superuser. The tricky part: We can make the operator change the password, but the pods have to be replaced immediately afterwards to keep the system (replication) running.

Therefore, the idea of this PR is to tag pods with rolling update annotation from within the updateSecret method. Because the secret is only updated at the end of updateSecret we cannot rotate pods immediately. For pooler pods this requires some extra login while syncing pooler objects: Listing pods, check for annotation and delete if found.

ToDos for future PRs:

  • System users can only be rotated when mentioned in the manifest. Should the global toggle enable_password_rotation incl. system users as well, or should there be an extra config option instead?
  • Passwords can also be rotated if we mount the secrets as volumes and provide a config structure within the secret. updateSecret can update that structure and only call the Patroni reload endpoint, without replacing the pods.

@FxKu FxKu added this to the 1.9 milestone Jul 15, 2022
@FxKu
Copy link
Member Author

FxKu commented Aug 16, 2022

👍

1 similar comment
@Jan-M
Copy link
Member

Jan-M commented Aug 18, 2022

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants