Fix (#2644) - Add json tags to InfrastructureRole struct

[hemakshis]

Fixes: #2644

[FxKu]

Thanks. All the other mappings in this config file use name:... instead of json:.... Can you test if it also works with name?

EDIT: I think you're correct here with using json. Looks like this option is not supported by ConfigMap configuration anyway as the mapping is "-". Thanks for this finding.

re-EDIT: Actually we do use this option also via configmap with such a configuration: secretname:my-infrastructure-secret,userkey:myuser,passwordkey:mypw,defaultrolevalue:robot. So we have to check out first if it would continue to work with this JSON mapping.

[FxKu]

I feel we could also more tests and docs on this topic. But for now we can merge as is to include it into today's release.

[hemakshis]

It is working after adding name tag as well, do you want me to revert it? 😅

[hemakshis]

I feel we could also more tests and docs on this topic. But for now we can merge as is to include it into today's release.

Yes, docs are very confusing and each doc file gives some extra information which is not present in another. It would be good to make it consistent for all the ways we can provide these infra roles - CRD, ConfigMap and then both Only secrets & both Secret+ConfigMap.

[FxKu]

👍

[idanovinda]

👍