Enable slot and publication deletion when stream application is removed #2684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
reviewed
Jul 5, 2024
idanovinda
requested review from
sdudoladov,
Jan-M,
jopadi,
hughcapet and
macedigital
as code owners
* refactor syncStreams() by making few variables as a struct * filtering publication to just get the ones created by postgres user
Co-authored-by: Ida Novindasari [email protected]
FxKu
reviewed
Jul 19, 2024
FxKu
reviewed
Jul 24, 2024
FxKu
reviewed
Jul 24, 2024
FxKu
reviewed
Jul 24, 2024
Co-authored-by: Felix Kunde <[email protected]>
Co-authored-by: Felix Kunde <[email protected]>
Co-authored-by: Felix Kunde <[email protected]>
idanovinda
commented
Jul 24, 2024
FxKu
reviewed
Jul 24, 2024
Co-authored-by: Felix Kunde <[email protected]>
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #2563
The current behaviour of our operator for the stream section allows us to create FES resources. During the creation, the postgres-operator will create FES resources, publications, and replication slots. However, during deletion (when user drop the stream section from the manifest), operator only removes the FES resources, while publications and replications are not deleted. This results in need for manual deletion by someone who has administrator roles.
Changes:
syncPublication()to allow sync publication (CRUD) per databasecreateOrUpdateStream()to allow resource deletion when removed from manifest