Skip to content

Use map(str, *) in test_accessed_chunks #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2024
Merged

Use map(str, *) in test_accessed_chunks #2229

merged 3 commits into from
Sep 25, 2024

Conversation

jakirkham
Copy link
Member

Slight simplification of logic in test_accessed_chunks

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jakirkham jakirkham mentioned this pull request Sep 24, 2024
Merged
6 tasks
@d-v-b
Copy link
Contributor

d-v-b commented Sep 25, 2024

seems like pre-commit is failing in the ruff format stage, but i don't see an error message in the logs for that ci job

@jhamman
Copy link
Member

jhamman commented Sep 25, 2024

pre-commit.ci autofix

@jhamman jhamman merged commit 3ce7670 into zarr-developers:v3 Sep 25, 2024
26 checks passed
@jakirkham jakirkham deleted the use_map_str_tst_accessed branch September 26, 2024 01:14
@jakirkham
Copy link
Member Author

Thanks all! 🙏

d-v-b pushed a commit to d-v-b/zarr-python that referenced this pull request Sep 26, 2024
@jakirkham @pre-commit-ci
@jhamman @d-v-b
Use map(str, *) in test_accessed_chunks (zarr-developers#2229)
748e58b 
* Update test_indexing.py

* style: pre-commit fixes

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Joe Hamman <[email protected]>
dcherian added a commit to dcherian/zarr-python that referenced this pull request Sep 27, 2024
@dcherian
Merge branch 'v3' into generalize-stateful-store
ae3bca5 
* v3: (21 commits)
  Default zarr.open to open_group if shape is not provided (zarr-developers#2158)
  feat: metadata-only support for storage transformers metadata (zarr-developers#2180)
  fix(async): set default concurrency to 10 tasks (zarr-developers#2256)
  chore(deps): drop support for python 3.10 and numpy 1.24 (zarr-developers#2217)
  feature(store): add LoggingStore wrapper (zarr-developers#2231)
  Apply assorted ruff/flake8-simplify rules (SIM) (zarr-developers#2259)
  Add array storage helpers (zarr-developers#2065)
  Apply ruff/flake8-annotations rule ANN204 (zarr-developers#2258)
  No need to run DeepSource any more - we use ruff (zarr-developers#2261)
  Remove unnecessary lambda expression (zarr-developers#2260)
  Enforce ruff/flake8-comprehensions rules (C4) (zarr-developers#2239)
  Use `map(str, *)` in `test_accessed_chunks` (zarr-developers#2229)
  Replace Gitter with Zulip (zarr-developers#2254)
  Enforce ruff/flake8-pytest-style rules (PT) (zarr-developers#2236)
  Fix multiple identical imports (zarr-developers#2241)
  Enforce ruff/flake8-return rules (RET) (zarr-developers#2237)
  Enforce ruff/flynt rules (FLY) (zarr-developers#2240)
  Fix fill_value handling for complex dtypes (zarr-developers#2200)
  Update V2 codec pipeline to use concrete classes (zarr-developers#2244)
  Apply and enforce more ruff rules (zarr-developers#2053)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakirkham @d-v-b @jhamman